New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate CustomPodDNS feature to GA #72832

Merged
merged 1 commit into from Feb 2, 2019

Conversation

@MrHohn
Copy link
Member

MrHohn commented Jan 11, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Graduates CustomPodDNS feature gate to GA and removes feature gate condition checks.

Which issue(s) this PR fixes:
Ref kubernetes/enhancements#504, #72651

Special notes for your reviewer:
/assign @bowei @liggitt

Does this PR introduce a user-facing change?:

The CustomPodDNS feature gate has graduated to GA, and can no longer be disabled. The feature gate will be removed in v1.16
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 11, 2019

/approve

lgtm, will leave final lgtm for @kubernetes/sig-network-pr-reviews

@MrHohn MrHohn force-pushed the MrHohn:pod-dns-config-ga branch from 2d446d4 to f2750dd Jan 11, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Jan 11, 2019

@MrHohn

This comment has been minimized.

Copy link
Member Author

MrHohn commented Jan 11, 2019

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 12, 2019

/retest

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Feb 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, liggitt, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrHohn

This comment has been minimized.

Copy link
Member Author

MrHohn commented Feb 2, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 2, 2019

@MrHohn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized f2750dd link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 235b32e into kubernetes:master Feb 2, 2019

17 of 18 checks passed

pull-kubernetes-local-e2e-containerized Job failed.
Details
cla/linuxfoundation MrHohn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Context retired without replacement.
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment