Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apimachinery/wait: add context-aware helpers #72928

Merged
merged 1 commit into from Jan 29, 2019
Merged

apimachinery/wait: add context-aware helpers #72928

merged 1 commit into from Jan 29, 2019

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Jan 15, 2019

This adds three context-aware helpers to the existing set of util/wait
wrappers. Those allow to link caller, wrapper, and inner function into
the same cancellation chain. It also allows to gracefully cancel inner
workload when the parent context expires.

Signed-off-by: Luca Bruno luca.bruno@coreos.com

What type of PR is this?

/kind cleanup

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @lucab. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 15, 2019
@lucab
Copy link
Contributor Author

lucab commented Jan 15, 2019

/sig api-machinery

@yue9944882
Copy link
Member

/ok-to-test

thx. there was a general goal to replace usage of stopCh to context in the codebase as many as possible.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2019
@lucab
Copy link
Contributor Author

lucab commented Jan 16, 2019

/cc @s-urbaniak @squat as we discussed this earlier, in case you have time for a cursory look.

@s-urbaniak
Copy link
Contributor

looks good! Just a small suggestion to reduce code duplication:

func JitterUntilWithContext(ctx context.Context, f func(context.Context), period time.Duration, jitterFactor float64, sliding bool) {
    JitterUntil(func() { f(ctx) }, period, jitterFactor, sliding, ctx.Done())
}

@lucab
apimachinery/wait: add context-aware helpers
c4f1568 
This adds three context-aware helpers to the existing set of `util/wait`
wrappers. Those allow to link caller, wrapper, and inner function into
the same cancellation chain. It also allows to gracefully cancel inner
workload when the parent context expires.

Signed-off-by: Luca Bruno <luca.bruno@coreos.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2019
@lucab
Copy link
Contributor Author

lucab commented Jan 16, 2019

/test pull-kubernetes-e2e-kops-aws

@lucab
Copy link
Contributor Author

lucab commented Jan 16, 2019

@s-urbaniak thanks for the suggestion, updated to that.

@fedebongio
Copy link
Contributor

/assign @caesarxuchao @jingyih

@k8s-ci-robot
Copy link
Contributor

@fedebongio: GitHub didn't allow me to assign the following users: jingyih.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @caesarxuchao @jingyih

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucab
Copy link
Contributor Author

lucab commented Jan 18, 2019

@sttts any chance you can give a quick look/stamp at this? It would allow a bit cleaner context chaining in consumers (viz., operators).

caesarxuchao
caesarxuchao reviewed Jan 23, 2019
View reviewed changes
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@yue9944882 do you know who's leading the context/stopCh refactor?

staging/src/k8s.io/apimachinery/pkg/util/wait/wait_test.go Show resolved Hide resolved
@sttts
Copy link
Contributor

sttts commented Jan 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucab, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 7277015 into kubernetes:master Jan 29, 2019
@lucab lucab mentioned this pull request Jan 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@sttts sttts

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lucab @k8s-ci-robot @yue9944882 @s-urbaniak @fedebongio @sttts @fejta-bot @caesarxuchao