Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing scheduler benchmark #73054

Closed
wants to merge 1 commit into from
Closed

Fix failing scheduler benchmark #73054

wants to merge 1 commit into from
+6 −4

Conversation

misterikkit
Copy link

@misterikkit misterikkit commented Jan 18, 2019 •
edited
Loading

What this PR does / why we need it:

We accidentally removed the Recorder object from integration test
scheduler in #71875. This
caused segfaults when running scheduler benchmarks.

make test-integration WHAT="./test/integration/scheduler_perf" KUBE_TEST_ARGS="-run xx -bench ."

This change adds the recorder back.

What type of PR is this?
/kind failing-test
/sig scheduling

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Set scheduler event recorder in tests.
ab7c2ea 
We accidentally removed the Recorder object from integration test
scheduler in kubernetes#71875. This
caused segfaults when running scheduler benchmarks.

    make test-integration WHAT="./test/integration/scheduler_perf" KUBE_TEST_ARGS="-run xx -bench ."

This change adds the recorder back.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2019
@misterikkit
Copy link
Author

/assign @bsalamat

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

@misterikkit: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify ab7c2ea link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bsalamat
bsalamat reviewed Jan 18, 2019
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Please update bazel files.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bsalamat, misterikkit
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rramkumar1

If they are not already assigned, you can assign the PR to them by writing /assign @rramkumar1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wgliang
Copy link
Contributor

wgliang commented Jan 18, 2019

wow, duplicate with #72967

@yastij
Copy link
Member

yastij commented Jan 18, 2019

/lgtm

from events POV.

@misterikkit
Copy link
Author

misterikkit commented Jan 18, 2019 •
edited
Loading

wow, duplicate with #72967

I failed to notice that one! It should be merged instead of this one.
/close

@k8s-ci-robot
Copy link
Contributor

@misterikkit: Closed this PR.

In response to this:

wow, duplicate with #72967

I failed to notice that one! I should be merged instead of this one.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat left review comments

@erictune erictune Awaiting requested review from erictune

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@yastij yastij

@bsalamat bsalamat

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@misterikkit @k8s-ci-robot @wgliang @yastij @bsalamat