Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not move deletionTimestamp to the future #73138

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jan 21, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
API doc for the deletionTimestamp field indicates that once a value is set, it may not be moved into the future. However, the generic store does that.

Which issue(s) this PR fixes:
Fixes #73098

Does this PR introduce a user-facing change?:

metadata.deletionTimestamp is no longer moved into the future when issuing repeated DELETE requests against a resource containing a finalizer.

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver labels Jan 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
@liggitt
Copy link
Member Author

liggitt commented Jan 21, 2019

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Jan 21, 2019

/retest

@dims
Copy link
Member

dims commented Jan 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2019
@danielqsj
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5617286 into kubernetes:master Jan 22, 2019
@liggitt liggitt deleted the deletionTimestamp branch January 22, 2019 18:34
@rcernich
Copy link

rcernich commented May 7, 2019

Any plans to back port the fix for this to older versions? I'm using a conflict error loop to account for this in my operator (which adds a finalizer to a customer resource), but the window for retry is pretty small (looks like there's a 1s delay between syncs in the namespace controller, so 1s to get current instance, remove finalizer, update) and I'm concerned it may still fail intermittently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants