-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not move deletionTimestamp to the future #73138
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/lgtm |
/lgtm |
Any plans to back port the fix for this to older versions? I'm using a conflict error loop to account for this in my operator (which adds a finalizer to a customer resource), but the window for retry is pretty small (looks like there's a 1s delay between syncs in the namespace controller, so 1s to get current instance, remove finalizer, update) and I'm concerned it may still fail intermittently. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
API doc for the deletionTimestamp field indicates that once a value is set, it may not be moved into the future. However, the generic store does that.
Which issue(s) this PR fixes:
Fixes #73098
Does this PR introduce a user-facing change?:
/sig api-machinery