Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shellcheck in csi-api #73219

Merged
merged 1 commit into from Feb 8, 2019
Merged

fix shellcheck in csi-api #73219

merged 1 commit into from Feb 8, 2019

Conversation

danielqsj
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

fix shellcheck failures in staging/src/k8s.io/csi-api

Which issue(s) this PR fixes:

work towards #72956

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2019
@danielqsj
Copy link
Contributor Author

/cc @BenTheElder

@fejta
Copy link
Contributor

fejta commented Jan 24, 2019

/approve
/lgtm
/assign @saad-ali @soltysh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2019
@fejta
Copy link
Contributor

fejta commented Jan 24, 2019

/retest

@danielqsj
Copy link
Contributor Author

@saad-ali @jsafrane @soltysh if you have time, can you help review this? Thanks

@sttts
Copy link
Contributor

sttts commented Jan 28, 2019

/approve

@sttts
Copy link
Contributor

sttts commented Jan 28, 2019

/assign @jsafrane

Can you approve?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 7, 2019
@danielqsj
Copy link
Contributor Author

rebased
@jsafrane can you help review it ?

@jsafrane
Copy link
Member

jsafrane commented Feb 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019
@jsafrane
Copy link
Member

jsafrane commented Feb 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, fejta, jsafrane, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@nikhita
Copy link
Member

nikhita commented Feb 8, 2019

/sig storage
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2019
@nikhita
Copy link
Member

nikhita commented Feb 8, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 30397a3 into kubernetes:master Feb 8, 2019
@BenTheElder BenTheElder mentioned this pull request Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@fejta fejta Awaiting requested review from fejta

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@soltysh soltysh

@fejta fejta

@jsafrane jsafrane

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@danielqsj @fejta @sttts @jsafrane @k8s-ci-robot @nikhita @soltysh @saad-ali