-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl run --quiet suppresses deletion messages #73266
kubectl run --quiet suppresses deletion messages #73266
Conversation
Hi @awh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.
thank you for the PR @awh
this change now waits for approval by SIG CLI.
/ok-to-test
/kind bug
/priority backlog
/retest |
2 similar comments
/retest |
/retest |
ISTM the test is failing due to an out of resource condition:
I'll give it one last try and then report to /retest |
The `--quiet` option should prevent kubectl run from polluting the output from an attached container - make it apply to the resource deletion messages caused by `--rm`.
ee597f4
to
c9dd2a2
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awh, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
--quiet
option should preventkubectl run
from polluting the output of an attached container - make it apply to the resource deletion messages emitted by the--rm
option.What type of PR is this?
/kind feature
What this PR does / why we need it:
kubectl run --quiet --rm
defies expectations by mixing messages about resource deletion into the output from an attached container.Does this PR introduce a user-facing change?: