Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl run --quiet suppresses deletion messages #73266

Merged
merged 1 commit into from Feb 26, 2019

Conversation

@awh
Copy link
Contributor

awh commented Jan 24, 2019

The --quiet option should prevent kubectl run from polluting the output of an attached container - make it apply to the resource deletion messages emitted by the --rm option.

What type of PR is this?

/kind feature

What this PR does / why we need it:

kubectl run --quiet --rm defies expectations by mixing messages about resource deletion into the output from an attached container.

Does this PR introduce a user-facing change?:

The `--quiet` option to `kubectl run` now suppresses resource deletion messages emitted when the `--rm` option is specified.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 24, 2019

Hi @awh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

neolit123 left a comment

SGTM.
thank you for the PR @awh
this change now waits for approval by SIG CLI.

/ok-to-test
/kind bug
/priority backlog

@awh

This comment has been minimized.

Copy link
Contributor Author

awh commented Jan 28, 2019

/retest

2 similar comments
@awh

This comment has been minimized.

Copy link
Contributor Author

awh commented Jan 28, 2019

/retest

@awh

This comment has been minimized.

Copy link
Contributor Author

awh commented Jan 28, 2019

/retest

@awh

This comment has been minimized.

Copy link
Contributor Author

awh commented Jan 29, 2019

ISTM the test is failing due to an out of resource condition:

W0128 16:38:26.075] ERROR: (gcloud.compute.instances.create) Could not fetch resource:
W0128 16:38:26.075]  - The zone 'projects/k8s-jkns-gci-garbage/zones/us-central1-f' does not have enough resources available to fulfill the request.  '(resource type:pd-standard)'.
W0128 16:38:26.075] Failed to create master instance due to non-retryable error
W0128 16:38:26.075] Some commands failed.

I'll give it one last try and then report to #testing-ops on the k8s slack

/retest

kubectl run --quiet suppresses deletion messages
The `--quiet` option should prevent kubectl run from polluting the
output from an attached container - make it apply to the resource
deletion messages caused by `--rm`.

@awh awh force-pushed the awh:kubectl-run-suppress-resource-deletion-messages-when-quiet branch from ee597f4 to c9dd2a2 Feb 25, 2019

@liggitt liggitt added kind/feature and removed kind/bug labels Feb 26, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 26, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awh, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e9a8d27 into kubernetes:master Feb 26, 2019

16 checks passed

cla/linuxfoundation awh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.