Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use forward plugin instead of proxy plugin in the default configuration of CoreDNS #73267

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Use forward plugin instead of proxy plugin in the default configuration of CoreDNS #73267

merged 1 commit into from
Jan 29, 2019

Conversation

rajansandeep
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Modify the default corefile configuration of CoreDNS to use the forward plugin instead of the proxy plugin.

Which issue(s) this PR fixes:

Fixes #73254

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The CoreDNS configuration now has the forward plugin for proxy in the default configuration instead of the proxy plugin.

/cc @chrisohaver

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 24, 2019
rosti
rosti reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajansandeep ! Looks good from kubeadm perspective.
/assign @fabriziopandini @timothysc

chrisohaver
chrisohaver approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@chrisohaver chrisohaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corefile syntax lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2019
fabriziopandini
fabriziopandini approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kubeadm part is ok; for the CoreDNS part I'm echoing @chrisohaver comment
/approve
/lgtm

@rajansandeep
Copy link
Contributor Author

/assign @MrHohn

MrHohn
MrHohn approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit c501d46 into kubernetes:master Jan 29, 2019
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
Adapt CoreDNS to recommended default configuration
fbcf14e 
See kubernetes/kubernetes#74137
See kubernetes/kubernetes#73267
See coredns/coredns#2629
@s-tokutake s-tokutake mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosti rosti rosti left review comments

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@MrHohn MrHohn MrHohn approved these changes

@chrisohaver chrisohaver chrisohaver approved these changes

Assignees

@timothysc timothysc

@fabriziopandini fabriziopandini

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CoreDNS to use forward plugin instead of proxy
7 participants
@rajansandeep @k8s-ci-robot @rosti @fabriziopandini @MrHohn @chrisohaver @timothysc