New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forward plugin instead of proxy plugin in the default configuration of CoreDNS #73267

Merged
merged 1 commit into from Jan 29, 2019

Conversation

@rajansandeep
Copy link
Member

rajansandeep commented Jan 24, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Modify the default corefile configuration of CoreDNS to use the forward plugin instead of the proxy plugin.

Which issue(s) this PR fixes:

Fixes #73254

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The CoreDNS configuration now has the forward plugin for proxy in the default configuration instead of the proxy plugin. 

/cc @chrisohaver

@rosti
Copy link
Member

rosti left a comment

Thanks @rajansandeep ! Looks good from kubeadm perspective.
/assign @fabriziopandini @timothysc

@chrisohaver
Copy link
Contributor

chrisohaver left a comment

Corefile syntax lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 25, 2019

@fabriziopandini
Copy link
Contributor

fabriziopandini left a comment

The kubeadm part is ok; for the CoreDNS part I'm echoing @chrisohaver comment
/approve
/lgtm

@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented Jan 29, 2019

/assign @MrHohn

@MrHohn

MrHohn approved these changes Jan 29, 2019

Copy link
Member

MrHohn left a comment

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c501d46 into kubernetes:master Jan 29, 2019

18 checks passed

cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment