Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/framework: validate external node IPs #73436

Closed
wants to merge 1 commit into from
Closed

test/e2e/framework: validate external node IPs #73436

wants to merge 1 commit into from

Commits on Jan 28, 2019

  1. test/e2e/framework: validate external node IPs 

    It is possible for a node not to have an external IP address. This extra
check is copied directly from GetNodeInternalIP and prevents errors like
the following:

    INFO: Getting external IP address for ip-10-0-133-82.ec2.internal
    error dialing core@:22: 'dial tcp :22: connect: connection refused'

In this case, there was no public IP for this host, but
GetNodeExternalIP returned ":22" instead of an error.
    @crawford
    crawford committed Jan 28, 2019
    Copy the full SHA
    7378ebc View commit details
    Browse the repository at this point in the history