Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSI Migration feature flags for Cinder In tree Driver #73840

Merged
merged 1 commit into from Mar 6, 2019
Merged

Add CSI Migration feature flags for Cinder In tree Driver #73840

merged 1 commit into from Mar 6, 2019

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Feb 8, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add CSI Migration Feature flags to enable intree to csi migration for cinder intree driver, same as #73043 done for GCP and AWS.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Intree to CSI Migration for Cinder intree driver is verified for static provisioning case.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2019
@adisky
Copy link
Contributor Author

adisky commented Feb 8, 2019

/sig openstack
/sig storage

@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Feb 8, 2019
@adisky
Copy link
Contributor Author

adisky commented Feb 8, 2019

cc @dims @ddebroy @davidz627

@adisky
Copy link
Contributor Author

adisky commented Feb 8, 2019

/assign @dims

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 8, 2019
dims
dims reviewed Feb 8, 2019
View reviewed changes
pkg/features/kube_features.go Outdated Show resolved Hide resolved
davidz627
davidz627 reviewed Feb 8, 2019
View reviewed changes
pkg/features/kube_features.go Outdated Show resolved Hide resolved
pkg/features/kube_features.go Outdated Show resolved Hide resolved
@dims
Copy link
Member

dims commented Feb 9, 2019

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Feb 9, 2019
@adisky adisky force-pushed the cinder-intree-migration branch 2 times, most recently from b30393c to 2d990bf Compare February 11, 2019 07:37
@dims
Copy link
Member

dims commented Feb 11, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2019
@davidz627
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 15, 2019
@dims
Copy link
Member

dims commented Feb 18, 2019

/assign @saad-ali @liggitt

Saad, Jordan, quick/easy PR it touches the pkg/features, hence escalating to you.

Thanks!

@liggitt
Copy link
Member

liggitt commented Feb 18, 2019

/unassign

@saad-ali is in the feature approvers alias along with other sig leads

@leakingtapan
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 1, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2019
@davidz627 davidz627 mentioned this pull request Mar 5, 2019
Closed
1 task
@adisky adisky mentioned this pull request Mar 6, 2019
Closed
@dims
Copy link
Member

dims commented Mar 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@ddebroy
Copy link
Member

ddebroy commented Mar 6, 2019

/assign @saad-ali

saad-ali
saad-ali approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adisky, dims, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit c80e45f into kubernetes:master Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

@adisky: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 3090b63 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 davidz627 left review comments

@dims dims dims approved these changes

@saad-ali saad-ali saad-ali approved these changes

@msau42 msau42 Awaiting requested review from msau42

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

@leakingtapan leakingtapan

@davidz627 davidz627

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@adisky @dims @davidz627 @liggitt @leakingtapan @ddebroy @k8s-ci-robot @saad-ali