-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for first pod to termiante in PV test #73900
Conversation
/sig storage |
dad4514
to
e392dfb
Compare
/retest |
/cc @oomichi |
/approve I contemplated if it would be better to just make the two pods use the same fsgroup, but I think it would be good to test that it can be changed. |
local plugin will skip setting fsGroup if volume is mounted by other pods
e392dfb
to
00a7fc3
Compare
/lgtm |
/test pull-kubernetes-verify |
Thanks for updating, /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cofyc, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Local plugin skips setting fsGroup if volume is mounted by other pods. In "should be mountable" test, we must wait for first pod to terminate.
Example logs of a failing test:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: