-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify PreStop hook intended behavior in doc #74160
Conversation
/retest |
Does a preStop happen before grace period starts or does it count against grace period? Could be a smidge clearer, please. |
It counts against the grace period. Otherwise, LGTM. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
This doesn't require more review than it is getting, but thanks bot :)
…On Thu, Feb 21, 2019 at 11:10 AM fejta-bot ***@***.***> wrote:
This PR may require API review
<https://git.k8s.io/community/sig-architecture/api-review-process.md#what-apis-need-to-be-reviewed>
.
If so, when the changes are ready, complete the pre-review checklist and
request an API review
<https://git.k8s.io/community/sig-architecture/api-review-process.md#mechanics>
.
Status of requested reviews is tracked in the API Review project
<https://github.com/orgs/kubernetes/projects/13>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#74160 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVL88-cfb96MVNOP7k-eaqcg_aOW7ks5vPu8hgaJpZM4a-2KJ>
.
|
bd78eeb
to
729ed4e
Compare
I added "The Pod's termination grace period countdown begins before the PreStop hooked is executed." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
Fixes #55807
/kind documentation
/sig node