Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health plugin for CoreDNS in the DNS tests #74371

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Add health plugin for CoreDNS in the DNS tests #74371

merged 1 commit into from
Feb 22, 2019

Conversation

rajansandeep
Copy link
Contributor

@rajansandeep rajansandeep commented Feb 21, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Following #74137, where CoreDNS now has the readinessProbe checks, the health plugin is added to report that CoreDNS is healthy.

Also, update the proxy plugin to forward since forward is now the default.

Which issue(s) this PR fixes:

Failing DNS tests in https://k8s-testgrid.appspot.com/sig-network-gce#gci-gce-serial

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 21, 2019
@rajansandeep
Copy link
Contributor Author

/cc @MrHohn

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2019
@rajansandeep
Copy link
Contributor Author

/sig network
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 21, 2019
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 21, 2019
MrHohn
MrHohn approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019
@MrHohn
Copy link
Member

MrHohn commented Feb 21, 2019

Thanks for the quick fix!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit a07c73d into kubernetes:master Feb 22, 2019
This was referenced Feb 26, 2019
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 5, 2019
@k8s-ci-robot
Merge pull request #74687 from rajansandeep/automated-cherry-pick-of-…
6c1e64b 
…#74371-upstream-release-1.13

Automated cherry pick of #74371: add health plugin in the DNS tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@freehan freehan Awaiting requested review from freehan

@nicksardo nicksardo Awaiting requested review from nicksardo

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajansandeep @MrHohn @k8s-ci-robot