Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync CNI config in goroutine #74389

Merged
merged 1 commit into from
Feb 23, 2019
Merged

sync CNI config in goroutine #74389

merged 1 commit into from
Feb 23, 2019

Conversation

answer1991
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes #74388 .
Kubelet run a new goroutine to sync CNI config if the runtime is dockershim, which fix the unexpected NotReady status when Node's iops is full.

Which issue(s) this PR fixes:

Fixes #74388

Special notes for your reviewer:
Before this fix, sync CNI config in the status check is inappropriate.

Does this PR introduce a user-facing change?:

Fix the unexpected NotReady status when Node's iops is full if the runtime is dockershim.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @answer1991. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubelet sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2019
@answer1991
Copy link
Contributor Author

@resouer @zhangxiaoyu-zidif

PTAL

@answer1991
Copy link
Contributor Author

@changyaowei

PTAL

@answer1991
Copy link
Contributor Author

answer1991 commented Feb 22, 2019 •
edited
Loading

@dchen1107

PTAL

@zhangxiaoyu-zidif
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2019
@zhangxiaoyu-zidif
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 22, 2019
@changyaowei
Copy link
Contributor

We encounter the same question, LGTM

@zhangxiaoyu-zidif
Copy link
Contributor

exec hack/update-bazel.sh please, if you modify import.

@answer1991
Copy link
Contributor Author

@zhangxiaoyu-zidif

cool, already done. Thanks

@answer1991
Copy link
Contributor Author

/retest

@resouer
Copy link
Contributor

resouer commented Feb 22, 2019

The change looks good from kubelet view, but should be defer to Dan (@dcbw)

/assign @dcbw

@dcbw
Copy link
Member

dcbw commented Feb 22, 2019

Discussed with @squeed this morning. I think this is an acceptable workaround for now.

In the very near future we'd like to kill the periodic resync entirely and make the plugin choice more declarative, whether through a disk file or the kubelet ConfigMap (since dockershim doesn't have its own config options yet, they still go through Kubelet).

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: answer1991, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b77e4e2 into kubernetes:master Feb 23, 2019
@answer1991
Copy link
Contributor Author

@dcbw

Actually, we had already refactor CNI config using ConfigMap in our downstream K8S. But the implement has already broken the CNI specification. So this PR use this workaround to follow the CNI specification.

Please feel free to let me know if you need any help when you start to refactor these codes, me and @changyaowei would like to provide some helps.

@dcbw
Copy link
Member

dcbw commented Feb 23, 2019

@answer1991 I'm actually rethinking the ConfigMap bits; depending on the runtime you use (dockershim or crio or something else) kubelet may not be involved in the CNI decisions at all. So having any network plugin options in the kubelet config would be useless with a remote runtime like CRIO. Plus, dockershim is supposed to eventually also be a remote runtime and wouldn't use the kubelet options.

Which leads me to believe that perhaps the file-based approach is a better one for now, even if it isn't as "kubernetes-y".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node becomes to be NotReady when iops is full
7 participants
@answer1991 @k8s-ci-robot @zhangxiaoyu-zidif @changyaowei @resouer @dcbw @fejta-bot