Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cloudprovider specific volume limit predicates #74544

Merged
merged 1 commit into from Mar 8, 2019

Conversation

@gnufied
Copy link
Member

gnufied commented Feb 25, 2019

Fixes #72920

Deprecate AWS, Azure, GCE and Cinder specific volume limit predicates.

/sig storage
/sig scheduling

cc @bsalamat @ravisantoshgudimetla @msau42

@@ -79,12 +79,20 @@ const (
// CheckServiceAffinityPred defines the name of predicate checkServiceAffinity.
CheckServiceAffinityPred = "CheckServiceAffinity"
// MaxEBSVolumeCountPred defines the name of predicate MaxEBSVolumeCount.
// DEPRECATED

This comment has been minimized.

@msau42

msau42 Feb 25, 2019

Member

Where is the in-tree translation layer to CSI going to live? Directly in the CSI predicate? cc @davidz627

This comment has been minimized.

@gnufied

gnufied Feb 26, 2019

Author Member

I am thinking translation layer is going to live in attach_limit.go util file which is shared between volume plugins and scheduler. But as we discussed I am working on a proposal for using CSINodeInfo for storing attach limits and this detail will be more flexed out in that KEP - kubernetes/enhancements#730

This comment has been minimized.

@ravisantoshgudimetla

ravisantoshgudimetla Mar 6, 2019

Contributor

nit: I think adding a comment mentioning enhancements KEP PR within code as a comment might be helpful?

@wgliang
Copy link
Member

wgliang left a comment

When will it be truly deprecated? I mean that there is still relevant code in effect.

@misterikkit

This comment has been minimized.

Copy link
Contributor

misterikkit commented Feb 26, 2019

Is the replacement already available?

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Feb 26, 2019

@misterikkit Since we are in process of migrating in-tree volume plugins to CSI, there is already a CSI predicate available which handles all volume plugins and hence when using CSI volumes - the cloudprovider specific predicates are not required. We will be able to truly remove these predicates once CSI migration goes GA but we will have a translation layer as well, which would take care of handling in-tree volume plugins even if you are not using CSI.

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Feb 27, 2019

/kind feature
/priority important-soon

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Mar 5, 2019

/test pull-kubernetes-integration

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla left a comment

/lgtm

@bsalamat - Do you have any other suggestions? If not, can you add milestone PR?

@ravisantoshgudimetla

This comment has been minimized.

Copy link
Contributor

ravisantoshgudimetla commented Mar 6, 2019

/retest

@yastij

yastij approved these changes Mar 6, 2019

Copy link
Member

yastij left a comment

/lgtm

MaxEBSVolumeCountPred = "MaxEBSVolumeCount"
// MaxGCEPDVolumeCountPred defines the name of predicate MaxGCEPDVolumeCount.
// DEPRECATED

This comment has been minimized.

@yastij

yastij Mar 6, 2019

Member

Any timeline set to move these out of the scheduler ?

@childsb childsb added this to the v1.14 milestone Mar 6, 2019

@bsalamat
Copy link
Contributor

bsalamat left a comment

Thank you, @gnufied! I am glad that to see progress here. I have a minor comment.

@@ -79,12 +79,20 @@ const (
// CheckServiceAffinityPred defines the name of predicate checkServiceAffinity.
CheckServiceAffinityPred = "CheckServiceAffinity"
// MaxEBSVolumeCountPred defines the name of predicate MaxEBSVolumeCount.
// DEPRECATED

This comment has been minimized.

@bsalamat

bsalamat Mar 6, 2019

Contributor

Please point out what the replacement is in the comment. Without a clear replacement, deprecating an existing feature causes confusion.

This comment has been minimized.

@gnufied

gnufied Mar 7, 2019

Author Member

But it is mentioned right there!

// DEPRECATED
// All cloudprovider specific predicates are deprecated in favour of MaxCSIVolumeCountPred.

MaxCSIVolumeCountPred will support all these in-tree volume types via migration path we discussed. I am working on updating the Volume limit KEP as per what we discussed - kubernetes/enhancements#730 .

This comment has been minimized.

@gnufied

gnufied Mar 7, 2019

Author Member

MaxCSIVolumeCountPred will support these in-tree volume types even if you are not using CSI.

@bsalamat
Copy link
Contributor

bsalamat left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d5e4973 into kubernetes:master Mar 8, 2019

17 checks passed

cla/linuxfoundation gnufied authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.