Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update klog dependency #74837

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Update klog dependency #74837

merged 1 commit into from
Mar 7, 2019

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Mar 2, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update klog dependency to include recent changes, notably opening existing files with O_APPEND instead of O_TRUNC.

Does this PR introduce a user-facing change?:

Pre-existing log files are now opened with O_APPEND, instead of O_TRUNC. This helps prevent losing logs when components crash-loop, and also enables external log rotation utilities to truncate log files in-place without components extending log files to their pre-truncation sizes on subsequent writes.

@mtaufen mtaufen added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 2, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Mar 2, 2019

@dims @liggitt looks like kubernetes/klog#39 changed --logtostderr default from false to true. I'm worried this could break existing logging configurations because when set, it disables logs from being sent to files, even if --log_file is set (--alsologtostderr is the correct flag for enabling both file and stderr logging).

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 6, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Mar 6, 2019

Discussion on what to revert was resolved and merged in kubernetes/klog#50.
Updated this PR to include those changes.
@liggitt @dims PTAL.
The O_APPEND change is critical for log rotation on Windows, where we will use an external log rotation utility to truncate files in-place. Without O_APPEND, writers immediately extend the file back to its pre-truncation size.

@mtaufen mtaufen mentioned this pull request Mar 6, 2019
Merged
@dims
Copy link
Member

dims commented Mar 6, 2019

/approve

@mtaufen thanks for driving this!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@liggitt
Copy link
Member

liggitt commented Mar 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@mtaufen mtaufen added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mtaufen
Copy link
Contributor Author

mtaufen commented Mar 6, 2019

Had to run update-staging-godeps. Re-adding label after update.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2019
@mtaufen mtaufen added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtaufen
Copy link
Contributor Author

mtaufen commented Mar 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit eb95c27 into kubernetes:master Mar 7, 2019
@liggitt liggitt added this to the v1.14 milestone Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
4 participants
@mtaufen @dims @liggitt @k8s-ci-robot