Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope slow/failing webhook to test namespace #74989

Merged
merged 1 commit into from Mar 6, 2019
Merged

Scope slow/failing webhook to test namespace #74989

merged 1 commit into from Mar 6, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 5, 2019

What type of PR is this?
/kind bug
/kind failing-test

What this PR does / why we need it:
#74562 added slow/failing webhook timeout tests. Other e2e tests run in parallel. This test should scope the webhook selector to a particular namespace to avoid disrupting other tests.

Which issue(s) this PR fixes:
xref #74984

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from ncdc and vishh March 5, 2019 19:58
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@spiffxp
Copy link
Member

spiffxp commented Mar 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@spiffxp
Copy link
Member

spiffxp commented Mar 5, 2019

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 5, 2019
@liggitt liggitt mentioned this pull request Mar 5, 2019
Closed
@roycaihw
Copy link
Member

roycaihw commented Mar 5, 2019

/lgtm

@liggitt thanks for fixing this

@timothysc timothysc added this to the v1.14 milestone Mar 5, 2019
@liggitt
Copy link
Member Author

liggitt commented Mar 5, 2019

pull-kubernetes-e2e-gce is green

@k8s-ci-robot k8s-ci-robot merged commit 3213a6d into kubernetes:master Mar 6, 2019
@liggitt liggitt deleted the webhook-test-namespace branch March 6, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@vishh vishh Awaiting requested review from vishh

Assignees

@spiffxp spiffxp

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @spiffxp @roycaihw @timothysc