Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission webhook: timeout configuration #74562

Merged
merged 6 commits into from Feb 27, 2019

Conversation

@roycaihw
Copy link
Member

roycaihw commented Feb 26, 2019

Add a configuration field to shorten the timeout of the webhook call. Part of admission webhooks to GA.

Does this PR introduce a user-facing change?:

Add a configuration field to shorten the timeout of validating/mutating admission webhook call. The timeout value must be between 1 and 30 seconds. Default to 30 seconds when unspecified. 
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 26, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt added the api-review label Feb 26, 2019

@liggitt liggitt added this to In progress in API Reviews Feb 26, 2019

@liggitt liggitt self-assigned this Feb 26, 2019

@liggitt liggitt moved this from In progress to Changes requested in API Reviews Feb 26, 2019

roycaihw added some commits Feb 26, 2019

@roycaihw roycaihw force-pushed the roycaihw:feat/admission-webhook-timeout branch from 458a425 to 1a25ced Feb 26, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 27, 2019

/retest

@liggitt liggitt moved this from Changes requested to In progress in API Reviews Feb 27, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 27, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 27, 2019

@liggitt liggitt added this to the v1.14 milestone Feb 27, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt removed this from In progress in API Reviews Feb 27, 2019

@liggitt liggitt removed the api-review label Feb 27, 2019

@k8s-ci-robot k8s-ci-robot merged commit 218642e into kubernetes:master Feb 27, 2019

16 checks passed

cla/linuxfoundation roycaihw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

mbohlool added a commit to mbohlool/kubernetes.github.io that referenced this pull request Mar 13, 2019

mbohlool added a commit to mbohlool/kubernetes.github.io that referenced this pull request Mar 14, 2019

mbohlool added a commit to mbohlool/kubernetes.github.io that referenced this pull request Mar 15, 2019

k8s-ci-robot added a commit to kubernetes/website that referenced this pull request Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.