Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: external snapshotter #75133

Merged
merged 2 commits into from
Mar 10, 2019
Merged

e2e: external snapshotter #75133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
915d636
e2e/storage: fix snapshot support in external driver testing
pohly Mar 7, 2019
e84271e
e2e/storage: allow empty volume type
pohly Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/e2e/storage/external/external.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ func (d *driverDefinition) SkipUnsupportedTest(pattern testpatterns.TestPattern)
supported := false
// TODO (?): add support for more volume types
switch pattern.VolType {
case "":
supported = true
case testpatterns.DynamicPV:
if d.StorageClass.FromName || d.StorageClass.FromFile != "" {
supported = true
Expand Down Expand Up @@ -253,7 +255,7 @@ func (d *driverDefinition) GetSnapshotClass(config *testsuites.PerTestConfig) *u
framework.Skipf("Driver %q does not support snapshotting - skipping", d.DriverInfo.Name)
}

snapshotter := config.GetUniqueDriverName()
snapshotter := d.DriverInfo.Name
parameters := map[string]string{}
ns := config.Framework.Namespace.Name
suffix := snapshotter + "-vsc"
Expand Down