Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label on UpdateContainerResources operation #75278

Merged

Conversation

@Nessex
Copy link
Contributor

commented Mar 12, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This fixes the label on exported metrics to do with the UpdateContainerResources operation. They are currently recorded as container_status, but there is already a ContainerStatus operation using that label as well. Note that this uses update_container instead of update_container_resources as that is what the corresponding docker instrumented operation reports.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

UpdateContainerResources is no longer recorded as a `container_status` operation. It now uses the label `update_container`
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Hi @Nessex. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nessex

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

/assign @dchen1107

@Nessex

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

/unassign dchen1107

@Nessex

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

/assign Random-Liu

@Nessex

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

/auto-cc

@k8s-ci-robot k8s-ci-robot requested review from dashpole and tmrts Apr 10, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

/ok-to-test
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 11, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

/priority important-soon

@derekwaynecarr

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

looks like a copy/paste bug.

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, Nessex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented Apr 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@Nessex

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

Thank you both!
/test pull-kubernetes-kubemark-e2e-gce-big

@Nessex

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@Nessex

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

Looks like the test issue is this one: #76490

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 097d585 into kubernetes:master Apr 12, 2019

18 checks passed

cla/linuxfoundation Nessex authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.