Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{WIP} Capture total mount/unmount operation time #75384

Open
wants to merge 2 commits into
base: master
from

Conversation

@gnufied
Copy link
Member

gnufied commented Mar 14, 2019

Another attempt to capture total mount and unmount operation time.

These metrics are different from current mount/unmount metrics because these(new) metrics capture total time taken from time a pod enters kubelet's volumemanager to time volume is actually mounted. So it includes time spent in things like - waiting for secret/configmap or volume to be attached etc.

Similarly for unmount it captures time taken for verifying if volume should be unmounted and everything else.

Hopefully, these metrics will be more representative of actual mount and unmount timings.

/sig storage

cc @msau42

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 14, 2019

@gnufied: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied gnufied force-pushed the gnufied:emit-total-volume-metrics branch from ad5e184 to 663494b Mar 15, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Mar 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: saad-ali

If they are not already assigned, you can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied gnufied force-pushed the gnufied:emit-total-volume-metrics branch from 18a54d1 to b06f201 Mar 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 19, 2019

@gnufied: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test b06f201 link /test pull-kubernetes-bazel-test
pull-kubernetes-verify b06f201 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.