Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable HTTP2 ingress test #75411

Merged
merged 1 commit into from
Mar 16, 2019
Merged

disable HTTP2 ingress test #75411

merged 1 commit into from
Mar 16, 2019

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Mar 15, 2019

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 15, 2019
MrHohn
MrHohn approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MrHohn
Copy link
Member

MrHohn commented Mar 15, 2019

Will need milestone 1.14 for this PR to be merged.
cc @mariantalla

@freehan freehan added this to the v1.14 milestone Mar 15, 2019
@MrHohn
Copy link
Member

MrHohn commented Mar 15, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

1 similar comment
@freehan
Copy link
Contributor Author

freehan commented Mar 15, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@MrHohn
Copy link
Member

MrHohn commented Mar 15, 2019

/kind test

@mariantalla
Copy link
Contributor

Thanks for the heads up @freehan @MrHohn . Have I understood this right? :

  • the healthcheck endpoint of the gce loadbalancer api now returns type:http2
  • however to gce go client (used by the tests?) does not yet support http2 object type
  • => this PR is disabling the tests around ingress using http2
    • temporarily, until the vendored google.golang.org/api/compute/v1 gets updated to the version that can support http2 type healthchecks.

If I got this right, makes sense for now; however is there an plan (e.g. an issue somewhere) to reintroduce the tests? Is this behaviour covered with e2e tests somewhere else?

@MrHohn
Copy link
Member

MrHohn commented Mar 15, 2019

/kind failing-test

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 15, 2019
@MrHohn
Copy link
Member

MrHohn commented Mar 15, 2019

Ref kubernetes/ingress-gce#667.

As many of these ingress test cases are in fact GCP specific (e.g. HTTP2 isn't surfaced as a generic knob through Ingress API), it doesn't make much sense for them to present in k/k and block OSS release. It seems folks are working on porting these over and maintain them in k/ingress-gce instead.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@tpepper
Copy link
Member

tpepper commented Mar 16, 2019

Thanks for the heads up @freehan @MrHohn . Have I understood this right? :

  • the healthcheck endpoint of the gce loadbalancer api now returns type:http2

  • however to gce go client (used by the tests?) does not yet support http2 object type

  • => this PR is disabling the tests around ingress using http2

    • temporarily, until the vendored google.golang.org/api/compute/v1 gets updated to the version that can support http2 type healthchecks.

If I got this right, makes sense for now; however is there an plan (e.g. an issue somewhere) to reintroduce the tests? Is this behaviour covered with e2e tests somewhere else?

Summary like this would be very beneficial to have in the commit and PR description.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d156c09 into kubernetes:master Mar 16, 2019
@mariantalla mariantalla mentioned this pull request Mar 18, 2019
Closed
@MrHohn MrHohn mentioned this pull request Apr 3, 2019
Closed
This was referenced Apr 5, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 11, 2019
@k8s-ci-robot
Merge pull request #76214 from freehan/automated-cherry-pick-of-#7541…
bc1c1c7 
…1-upstream-release-1.12

Automated cherry pick of #75411: disable HTTP2 ingress test
k8s-ci-robot added a commit that referenced this pull request Apr 13, 2019
@k8s-ci-robot
Merge pull request #76212 from freehan/automated-cherry-pick-of-#7541…
dbb7ec0 
…1-upstream-release-1.13

Automated cherry pick of #75411: disable HTTP2 ingress test
@freehan freehan mentioned this pull request Apr 19, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 23, 2019
@k8s-ci-robot
Merge pull request #76841 from freehan/automated-cherry-pick-of-#7541…
2798181 
…1-upstream-release-1.11

Automated cherry pick of #75411: disable HTTP2 ingress test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

[Failing test] gce-cos-<branch>-ingress are timing out
6 participants
@freehan @k8s-ci-robot @MrHohn @mariantalla @fejta-bot @tpepper