Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to golang 1.12.1 official image #75422

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Move to golang 1.12.1 official image #75422

merged 2 commits into from
Mar 19, 2019

Conversation

dims
Copy link
Member

@dims dims commented Mar 16, 2019

We used 1.12.0 + hack to download 1.12.1 binaries as we were in a rush
on friday since the images were not published at that time. Let's remove
the hack now and republish the kube-cross image

Change-Id: I3ffff3283b6ca755320adfca3c8f4a36dc1c2b9e

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@dims
Move to golang 1.12.1 official image
da16e41 
We used 1.12.0 + hack to download 1.12.1 binaries as we were in a rush
on friday since the images were not published at that time. Let's remove
the hack now and republish the kube-cross image

Change-Id: I3ffff3283b6ca755320adfca3c8f4a36dc1c2b9e
@k8s-ci-robot
Copy link
Contributor

@dims: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2019
@dims
Copy link
Member Author

dims commented Mar 16, 2019

/assign @BenTheElder @ixdy

@dims
Copy link
Member Author

dims commented Mar 16, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 16, 2019
@dims
Copy link
Member Author

dims commented Mar 16, 2019

related to #75372

@dims
Copy link
Member Author

dims commented Mar 16, 2019

/assign @BenTheElder @ixdy @tpepper @spiffxp

@dims dims mentioned this pull request Mar 16, 2019
Closed
@dims
Copy link
Member Author

dims commented Mar 16, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims
Copy link
Member Author

dims commented Mar 16, 2019

/kind cleanup
/priority important-soon
/milestone v1.14

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 16, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 16, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 16, 2019
@dims
Copy link
Member Author

dims commented Mar 16, 2019

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Mar 16, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 16, 2019
@liggitt
Copy link
Member

liggitt commented Mar 16, 2019

Need to bump the version file as well to 1.12.1-2

@dims
Copy link
Member Author

dims commented Mar 16, 2019

Ack @liggitt

@ixdy if i remember right you had mentioned that we don't bump version numbers, is that the same for the -2 suffix too?

Jordan,
When Jeff responds, i will update the PR. If i am not reachable, please feel free to copy commits to another PR or update this one itself (i have clicked on "allow edits from maintainers" checkbox).

Thanks!

@neolit123
Copy link
Member

neolit123 commented Mar 18, 2019 •
edited
Loading

cc @jpbetz
hello, can you answer the above question related to the revision -2?

basically we had a custom golang 1.12.1 image for a couple of days, but now we need to use the official one, thus having a revision:

Need to bump the version file as well to 1.12.1-2

seems appropriate?

@ixdy
Copy link
Member

ixdy commented Mar 18, 2019

The first part of the kube-cross version (before the dash) refers to the golang version. The piece after the dash is the image revision. So v1.12.1-2 would be the correct version to use here.

@liggitt
Copy link
Member

liggitt commented Mar 18, 2019

If i am not reachable, please feel free to copy commits to another PR or update this one itself (i have clicked on "allow edits from maintainers" checkbox).

added a commit to bump to 1.12.1-2

@ixdy
Copy link
Member

ixdy commented Mar 18, 2019

/lgtm
/approve
/assign @javier-b-perez

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@liggitt
Copy link
Member

liggitt commented Mar 18, 2019

(need to build/push the new kube-cross image before CI will go green on this PR)

@javier-b-perez
Copy link
Contributor

I'm building the images now... should take ~2 hours.

@javier-b-perez
Copy link
Contributor

/test pull-kubernetes-cross

@javier-b-perez
Copy link
Contributor

the image k8s.gcr.io/kube-cross:v1.12.1-2 is available now

@liggitt
Copy link
Member

liggitt commented Mar 18, 2019

/retest

@dims
Copy link
Member Author

dims commented Mar 18, 2019

Thanks @liggitt @ixdy

@dims
Copy link
Member Author

dims commented Mar 18, 2019

and thanks @javier-b-perez !

@k8s-ci-robot k8s-ci-robot merged commit bcbf1bc into kubernetes:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@spiffxp spiffxp

@BenTheElder BenTheElder

@tpepper tpepper

@ixdy ixdy

@javier-b-perez javier-b-perez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
10 participants
@dims @k8s-ci-robot @liggitt @neolit123 @ixdy @javier-b-perez @spiffxp @BenTheElder @tpepper @amwat