Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote pod should be submitted and removed e2e test case to conformance #75473

Merged
merged 1 commit into from Apr 12, 2019
Merged

promote pod should be submitted and removed e2e test case to conformance #75473

merged 1 commit into from Apr 12, 2019

Conversation

pontiyaraja
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
promote should be submitted and removed e2e test case to conformance.

Which issue(s) this PR fixes:#68066

Fixes #68066

Special notes for your reviewer:
should be submitted and removed test case get removed from conformance test and converted it to e2e, please refer issue #68066 due to flaky, flaky watch is removed in the PR #73064

Does this PR introduce a user-facing change?:

NONE

/area deflake
/are conformance
/sig testing
/cc @dims @liggitt
/assign @spiffxp

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/deflake Issues or PRs related to deflaking kubernetes tests sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Mar 19, 2019
@spiffxp spiffxp added this to To Triage in conformance-definition Mar 20, 2019
spiffxp
spiffxp reviewed Mar 20, 2019
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we're ready to suggest this for promotion yet

test/conformance/testdata/conformance.txt Show resolved Hide resolved
test/e2e/node/pods.go Show resolved Hide resolved
@pontiyaraja pontiyaraja changed the title promote should be submitted and removed e2e test case to conformance promote pod should be submitted and removed e2e test case to conformance Mar 21, 2019
@pontiyaraja pontiyaraja mentioned this pull request Mar 21, 2019
Merged
@spiffxp spiffxp moved this from To Triage to In Review in conformance-definition Mar 23, 2019
@claudiubelu
Copy link
Contributor

FWIW, this test passes on Windows, so I'm ok with the promotion.

@timothysc timothysc added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 2, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 2, 2019
@timothysc timothysc added this to the v1.15 milestone Apr 2, 2019
@pontiyaraja
Copy link
Contributor Author

This test case didn't fail from 17-02-2019 to today 0 failures out of 151232 builds.
testRes
Please refer the link
https://storage.googleapis.com/k8s-gubernator/triage/index.html?date=2019-03-03&sig=node&test=Delete%20Grace%20Period%20should%20be%20submitted%20and%20removed

@vladimirvivien vladimirvivien mentioned this pull request Apr 4, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Apr 6, 2019

green runs with no flakes shown at https://testgrid.k8s.io/google-gce#gci-gce-flaky&width=5&include-filter-by-regex=should%20be%20submitted%20and%20removed

@liggitt
Copy link
Member

liggitt commented Apr 6, 2019

/lgtm
/hold

cc @kubernetes/cncf-conformance-wg for review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2019
@brahmaroutu brahmaroutu moved this from In Review to Needs Approval in conformance-definition Apr 8, 2019
conformance-definition automation moved this from Needs Approval to Done Apr 9, 2019
@pontiyaraja
Copy link
Contributor Author

@vladimirvivien I think your PR not fixing this.
/reopen

@k8s-ci-robot k8s-ci-robot reopened this Apr 9, 2019
conformance-definition automation moved this from Done to To Triage Apr 9, 2019
@k8s-ci-robot
Copy link
Contributor

@pontiyaraja: Reopened this PR.

In response to this:

@vladimirvivien I think your PR not fixing this.
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnbelamaric johnbelamaric moved this from To Triage to Sorted Backlog in conformance-definition Apr 9, 2019
@brahmaroutu brahmaroutu moved this from Sorted Backlog to Needs Approval in conformance-definition Apr 9, 2019
@brahmaroutu brahmaroutu moved this from Needs Approval to In Review in conformance-definition Apr 9, 2019
@timothysc timothysc moved this from In Review to Needs Approval in conformance-definition Apr 9, 2019
@smarterclayton
Copy link
Contributor

/approve
/hold cancel

(this was my flaky test so I'm glad someone was more responsible than me to fix it)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pontiyaraja, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2a6efd3 into kubernetes:master Apr 12, 2019
conformance-definition automation moved this from Needs Approval to Done Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@spiffxp spiffxp

@liggitt liggitt

@brahmaroutu brahmaroutu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/deflake Issues or PRs related to deflaking kubernetes tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

[k8s.io] Pods should be submitted and removed [Conformance] {E2eNode Suite}
8 participants
@pontiyaraja @claudiubelu @liggitt @k8s-ci-robot @smarterclayton @spiffxp @timothysc @brahmaroutu