Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet should request protobuf from the apiserver #75602

Merged
merged 1 commit into from Mar 22, 2019

Conversation

@smarterclayton
Copy link
Contributor

commented Mar 22, 2019

The kubelet was not asking for application/vnd.kubernetes.protobuf
on list and get calls. It looks like we lost that code when we
moved to cert rotation. Clean up the client initialization path
and make sure that all non-dynamic clients use protobuf by default.

A future change will fix it so that dynamic clients can also safely
use protobuf via negotiation.

/kind bug

The Kubelet now properly requests protobuf objects where they are
supported from the apiserver, reducing load in large clusters.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kubelet should request protobuf from the apiserver
The kubelet was not asking for application/vnd.kubernetes.protobuf
on list and get calls. It looks like we lost that code when we
moved to cert rotation. Clean up the client initialization path
and make sure that all non-dynamic clients use protobuf by default.
@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@kubernetes/sig-scalability-bugs

This regressed a very long time ago.

@mtaufen

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

/lgtm

@mtaufen

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3312da8 into kubernetes:master Mar 22, 2019

17 checks passed

cla/linuxfoundation smarterclayton authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.