Join GitHub today
Explicitly flush headers when proxying #75887
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
referenced this pull request
Mar 29, 2019
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liggitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
simonferquel left a comment
newFlushHeaderWriter should either return an error for writers not implementing http.Flusher, or be renamed something like tryWrapInFlushHeaderWriter (and potentially returning a
Also, even if the component only requires the flusher interface, it also checks for CloseNotifier and Hijacker interfaces. Is it relevant ? (If it is, a comment about that would be welcome).