Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-autorest to v11.1.2 #77070

Merged
merged 1 commit into from Apr 25, 2019

Conversation

@feiskyer
Copy link
Member

commented Apr 25, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

According to Azure/go-autorest#357, the timeout set in context doesn't take effect and 15min is always used for long running operations.

This PR upgradse the version of go-autorest to 11.1.2 so as to fix the issue.

Which issue(s) this PR fixes:

Fixes #75579

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade go-autorest to v11.1.2

/priority important-soon
/assign @liggitt @andyzhangx

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

according to Azure/go-autorest#357 (comment), this was fixed in v11.3.2, not v11.1.2

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

ah, nevermind, I see v11.1.2 was a special backport patch release - https://github.com/Azure/go-autorest/releases/tag/v11.1.2

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

/approve

will leave lgtm to @andyzhangx

@dims
dims approved these changes Apr 25, 2019
Copy link
Member

left a comment

/lgtm

Looks legit :) does not add anything new.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

oops need to let @andyzhangx take a look

/hold

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

thanks for all the effort to get these fixes in a non-disruptive way

@andyzhangx
Copy link
Member

left a comment

/lgtm
/test pull-kubernetes-e2e-aks-engine-azure

@dims

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 9e29c3e into kubernetes:master Apr 25, 2019

21 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@feiskyer feiskyer deleted the feiskyer:autorest-update branch Apr 25, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

thanks, @liggitt and @dims.

@feiskyer feiskyer added this to Done in Provider Azure Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.