Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record accurate end to end CSI provisioning latency/error count metrics #77376

Closed
wants to merge 44 commits into from
Closed

Record accurate end to end CSI provisioning latency/error count metrics #77376

wants to merge 44 commits into from

Conversation

yuxiangqian
Copy link
Contributor

@yuxiangqian yuxiangqian commented May 3, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Record accurate end to end latency for provisioning via CSI workflow.
Which issue(s) this PR fixes:

Fixes #77030

Special notes for your reviewer:
Deletion latency capturing to-be-implemented
unit testings created
e2e testing on going

Does this PR introduce a user-facing change?:
Metrics (end to end latency/error count) for provisioning PV and binding PVC to PV have not been correctly recorded for CSI workflow. Time taken by external provisioner to create a volume has not been taken into consideration. This PR is to enhance pv controller to record more accurate latency/error count metrics for users to consume.

NONE

RobertKrawitz and others added 14 commits April 5, 2019 18:29
@RobertKrawitz
Graduate SupportNodePidsLimit to beta
1c0d021
@dims
typo - extra space - in Fatalf format string
22ffdc6 
Change-Id: Ifeff0ee29aa6ccdc4c3ebdd2a071cebfafaf937e
@claudiubelu
Uses the resource-consumer/controller image instead of resource-consu…
53df13a 
…mer-controller

Dockerhub does not support slashes in the image names, so when the tests are
configured to use a dockerhub registry instead of the current
gcr.io/kubernetes-e2e-test-images registry, the tests using the mentioned image
will fail, as the image cannot exist and cannot be pulled.
@yuxiangqian
Merge pull request #1 from kubernetes/master
4589b19 
rebase
@yuxiangqian
Merge pull request #2 from kubernetes/master
d383cd8 
rebase
@yuxiangqian
Merge pull request #3 from kubernetes/master
cf35a44 
rebase
@MrHohn
Bump addon-manager to v9.0.1
037d4b3 
- Rebase image on debian-base:v1.0.0.
@yuxiangqian
Merge pull request #4 from kubernetes/master
2bf6327 
rebase from master
@yuxiangqian
report end to end latency for provisioning
e13e635
@yuxiangqian
adding unit tests for provisioning metric reporting via CSI driver
70b4b7f
@yuxiangqian
Merge pull request #5 from kubernetes/master
645d582 
rebase from master
@yuxiangqian
changing back to use tabs to reduce noises
6830df1
@yuxiangqian
remove unused variables for now
4935268
@yuxiangqian
comments
1caa0f6
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @yuxiangqian. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 3, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2019
@msau42
Copy link
Member

msau42 commented May 3, 2019

/assign

@SataQiu
fix golint failures of pkg/apis/scheduling pkg/apis/storage/util pkg/…
ed04c5f 
…apis/storage/v1/util pkg/apis/storage/v1beta1/util
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/cloudprovider area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuxiangqian
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: dims, thockin, vishh

If they are not already assigned, you can assign the PR to them by writing /assign @dims @thockin @vishh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuxiangqian yuxiangqian closed this May 6, 2019
@yuxiangqian
Copy link
Contributor Author

This is not correctly updated and causing lots of noise, sorry for the confusion. Will reopen another one

@yuxiangqian yuxiangqian mentioned this pull request May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@neolit123 neolit123 neolit123 left review comments

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
area/cloudprovider area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose end to end latency volume operation metrics via CSI