Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect prometheus azure metrics #77722

Merged
merged 1 commit into from May 13, 2019

Conversation

@andyzhangx
Copy link
Member

commented May 10, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Following azure metrics are wrong:

azLoadBalancersClient.CreateOrUpdate: load_balancers_create_or_update
azLoadBalancersClient.Delete: load_balancers_delete
azLoadBalancersClient.Get: public_ip_addresses_create_or_update
azRouteTablesClient.CreateOrUpdate: route_tables_create_or_update
azPublicIPAddressesClient: public_ip_addresses_delete
azVirtualMachineScaleSetVMsClient.Udate: vmssvm_update
azDisksClient.CreateOrUpdate: disks_create_or_update
azDisksClient.Delete: disks_delete

Which issue(s) this PR fixes:

Fixes #77721

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix incorrect prometheus azure metrics

/assign @feiskyer
/priority important-soon
/sig azure

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

/test pull-kubernetes-e2e-aks-engine-azure

1 similar comment
@justaugustus

This comment has been minimized.

Copy link
Member

commented May 10, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

/test pull-kubernetes-e2e-aks-engine-azure
@feiskyer PTAL

@feiskyer
Copy link
Member

left a comment

/lgtm
/approve
/test

@k8s-ci-robot k8s-ci-robot added the lgtm label May 13, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member

commented May 13, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@andyzhangx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure a33b86e link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 3bc595e into kubernetes:master May 13, 2019

20 of 21 checks passed

pull-kubernetes-e2e-aks-engine-azure Job failed.
Details
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request May 21, 2019
Merge pull request #77855 from andyzhangx/automated-cherry-pick-of-#7…
…7722-upstream-release-1.14

Automated cherry pick of #77722: fix incorrect prometheus metrics
k8s-ci-robot added a commit that referenced this pull request May 23, 2019
Merge pull request #78207 from andyzhangx/automated-cherry-pick-of-#7…
…7722-upstream-release-1.12

Automated cherry pick of #77722: fix incorrect prometheus metrics
k8s-ci-robot added a commit that referenced this pull request May 31, 2019
Merge pull request #78205 from andyzhangx/automated-cherry-pick-of-#7…
…7722-upstream-release-1.13

Automated cherry pick of #77722: fix incorrect prometheus metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.