Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
kubelet: fix fail to close kubelet->API connections on heartbeat failure #78016
What type of PR is this?
What this PR does / why we need it:
As discussed in kubernetes/client-go#374, another way to fix this is using http/2.0's ping frame to keep connection alive and identify failed connections. but it seems to be a long-term solution.
Which issue(s) this PR fixes:
Special notes for your reviewer:
related integration test is onging: #77957
Does this PR introduce a user-facing change?:
Hi @gaorong. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
May 17, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing