Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add the ability to migrate CoreDNS configmap in kubeadm #78033
What type of PR is this?
What this PR does / why we need it:
This approach is disadvantageous because this can lead to an incompatible Corefile which can lead to CoreDNS entering a
This PR adds the ability for users to seamlessly migrate their CoreDNS Configuration when they upgrade their clusters using kubeadm. The CoreDNS Migration library helps to handle migrations of CoreDNS Corefiles to be compatible with new versions of CoreDNS.
The PR includes 3 preflight-checks while upgrading to check:
The user will be provided Logs and can override these checks.
The user will be informed appropriately through logs.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This PR also updates the CoreDNS version to 1.5.0
neolit123 left a comment
thanks for the PR @rajansandeep
we might need at least some unit tests and possibly extend the release note that preflight checks are run now.
ideally more eyes from @kubernetes/sig-cluster-lifecycle-pr-reviews are needed here.
@rajansandeep Looks like the caddy dependency needs to be updated.
Can you please run:
And commit the changes? Then when complete, include a comment with the output of
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing