Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated flag --resource-container from kube-proxy #78294

Merged
merged 1 commit into from Jun 22, 2019

Conversation

@vllry
Copy link
Contributor

commented May 24, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes a long-deprecated field (--resource-container) from kube-proxy. This also removes the resourceContainer code, as kube-proxy was the last component to use it.

Which issue(s) this PR fixes:
Fixes #78287

Special notes for your reviewer:

  • If the user keeps the flag (EG as part of their bootstrap process), kube-proxy will fail to start, but the result may not be obvious. Is it okay to yank it all at once, or should we give a stronger warning when the flag is used and wait another release?
  • Should we worry about the API change compatibility? As far as I can tell, removing a deprecated admin flag/v1alpha API field is fine.

Does this PR introduce a user-facing change?:

ACTION REQUIRED: Removed deprecated flag `--resource-container` from kube-proxy.

The deprecated `--resource-container` flag has been removed from kube-proxy, and specifying it will now cause an error.  The behavior is now as if you specified `--resource-container=""`.  If you previously specified a non-empty `--resource-container`, you can no longer do so as of kubernetes 1.16.
@vllry

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

/priority backlog

@vllry vllry force-pushed the vllry:kp-remove-resource-container branch 2 times, most recently from 8f7f092 to 318b3fa May 24, 2019
@danwinship

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from danwinship May 24, 2019
@vllry

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

/uncc @bowei

Sorry for the spam :C (Of course I get this command wrong several times...)

@k8s-ci-robot k8s-ci-robot removed the request for review from bowei May 24, 2019
@vllry vllry force-pushed the vllry:kp-remove-resource-container branch from 65124af to e00ed66 May 24, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels May 24, 2019
@vllry vllry force-pushed the vllry:kp-remove-resource-container branch from f266200 to 6667837 May 26, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels May 26, 2019
@@ -138,9 +138,6 @@ type KubeProxyConfiguration struct {
// portRange is the range of host ports (beginPort-endPort, inclusive) that may be consumed
// in order to proxy service traffic. If unspecified (0-0) then ports will be randomly chosen.
PortRange string
// resourceContainer is the absolute name of the resource-only container to create and run
// the Kube-proxy in (Default: /kube-proxy).
ResourceContainer string

This comment has been minimized.

Copy link
@johscheuer

This comment has been minimized.

Copy link
@vllry

vllry Jun 16, 2019

Author Contributor

Thanks, I spotted that but I'm still missing something. All unit tests are fine, but the system doesn't start properly in e2e.

@vllry vllry force-pushed the vllry:kp-remove-resource-container branch from 308776d to 82eb8fc Jun 16, 2019
@vllry vllry force-pushed the vllry:kp-remove-resource-container branch from 3829fc6 to 3fd1807 Jun 16, 2019
@vllry

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

/test pull-kubernetes-bazel-build

1 similar comment
@vllry

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

/test pull-kubernetes-bazel-build

@vllry vllry changed the title WIP: Remove deprecated flag --resource-container from kube-proxy Remove deprecated flag --resource-container from kube-proxy Jun 16, 2019
@vllry vllry force-pushed the vllry:kp-remove-resource-container branch from 3fd1807 to dc0f143 Jun 16, 2019
@vllry

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

/assign @bowei
/assign @thockin

@thockin

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 19, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, vllry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

FYI added ```release-note in the release note block to fix the release-note label.

@k8s-ci-robot k8s-ci-robot merged commit eee3e97 into kubernetes:master Jun 22, 2019
23 checks passed
23 checks passed
cla/linuxfoundation vllry authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@justinsb

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Can we change the release note flag to be more instructive?

I suggest:

ACTION REQUIRED: Removed deprecated flag `--resource-container` from kube-proxy.

The --resource-container flag has been removed from kube-proxy.  The behaviour is now as if you specified `--resource-container=""`.  However, you must stop specifying `--resource-container=""`.  If you previously specified a non-empty `--resource-container`, you can no longer do so as of kubernetes 1.16.
justinsb added a commit to justinsb/kops that referenced this pull request Jul 8, 2019
Removed in kubernetes/kubernetes#78294

(A k/k breaking change: `--resource-container=""` is now the default!)
@thockin

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Updated

@zouyee

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.