Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint issues in pkg/kubelet/{prober,secret} #78347

Merged
merged 3 commits into from Jun 28, 2019
Merged

Fix golint issues in pkg/kubelet/{prober,secret} #78347

merged 3 commits into from Jun 28, 2019

Conversation

obitech
Copy link
Contributor

@obitech obitech commented May 25, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Improve code quality with removing golint issues in:

  • pkg/kubelet/prober/...
  • pkg/kubelet/secret

Which issue(s) this PR fixes:

Ref #68026

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @obitech. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 25, 2019
@obitech
Copy link
Contributor Author

obitech commented May 25, 2019 •
edited

/assign @Random-Liu

mattjmcnaughton
mattjmcnaughton approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

thanks for this change :)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2019
@obitech
Copy link
Contributor Author

obitech commented May 27, 2019

/test pull-kubernetes-e2e-gce

@obitech
Copy link
Contributor Author

obitech commented May 28, 2019

/assign @vishh

fejta
fejta reviewed May 28, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@obitech
Copy link
Contributor Author

obitech commented May 29, 2019

@mattjmcnaughton all tests are green now!

@mattjmcnaughton
Copy link
Contributor

sweet!

/lgtm

fejta
fejta reviewed Jun 3, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2019
@obitech obitech force-pushed the fix_golint_pkg_kubelet_prober branch from 7666c36 to cbdfccc Compare June 20, 2019 17:57
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 20, 2019
@obitech
Copy link
Contributor Author

obitech commented Jun 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
fejta
fejta approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@obitech
Copy link
Contributor Author

obitech commented Jun 26, 2019 •
edited

@mattjmcnaughton @derekwaynecarr is this mergable or are there any remaining issues with this PR?

@mattjmcnaughton
Copy link
Contributor

/assign @vishh

Someone from /pkg/kubelet/OWNERS (like @vishh ) will need to approve, and then you should be good to go.

fejta
fejta reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@fejta
Copy link
Contributor

fejta commented Jun 26, 2019

/assign Random-Liu dchen1107 derekwaynecarr tallclair vishh yujuhong

tallclair
tallclair reviewed Jun 27, 2019
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Some of the comments golint insists on annoy me, but I'd prefer to have golint checks.

pkg/kubelet/prober/testing/fake_manager.go

func (_ FakeManager) UpdatePodStatus(_ types.UID, podStatus *v1.PodStatus) {
// AddPod simulates adding a Pod.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would just say AddPod is unimplemented. Same below.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, obitech, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit dfb7748 into kubernetes:master Jun 28, 2019
@obitech obitech mentioned this pull request Aug 8, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@tallclair tallclair tallclair left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@fejta fejta

@mattjmcnaughton mattjmcnaughton

@Random-Liu Random-Liu

@derekwaynecarr derekwaynecarr

@vishh vishh

@dchen1107 dchen1107

@yujuhong yujuhong

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@obitech @k8s-ci-robot @mattjmcnaughton @fejta @tallclair @Random-Liu @derekwaynecarr @vishh @dchen1107 @yujuhong