Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dangling volume as uncertain #78595

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@gnufied
Copy link
Member

commented May 31, 2019

Adds dangling volumes to old nodes as uncertain, so as they can be detached and cleaned up by attach/detach controller.

Dangling volumes also aren't reported to node's status and hence can't be used by pods.

Fixes #77949

Fix issue with kubelet waiting on invalid devicepath on AWS
@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

/sig storage
/assign @jingxu97

@gnufied

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

/kind bug
/priority important-soon

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

lgtm-ish, but I don't know all the possible consequences, I'd prefer @jingxu97 to review properly.

@jingxu97

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 3, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

/kind bug

@saad-ali saad-ali removed the needs-kind label Jun 5, 2019

@saad-ali

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

/milestone v1.15
Bug fix
/hold
To allow @gnufied to address my feedback

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 5, 2019

@gnufied gnufied force-pushed the gnufied:fix-aws-dangling-volumes branch from e4963cc to 7bcebe9 Jun 6, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed lgtm size/XS labels Jun 6, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

addressed the comment.

/hold cancel

@dims

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

re-applying lgtm from @jingxu97

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 6, 2019

@k8s-ci-robot k8s-ci-robot merged commit 333081e into kubernetes:master Jun 6, 2019

21 checks passed

cla/linuxfoundation gnufied authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.