fix: retry detach azure disk issue #78700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fix gofmt issue
andyzhangx
force-pushed
the
azuredisk-detach-retry
branch
from
655dd8b
to
91f97d2
Compare
|
I deployed a build of |
|
I managed to reproduce and the backoff was not canceled this time 👍 However delays are still extremely long:
@andyzhangx is it worth opening a separate issue to discuss that? controller-manager logs: |
|
@antoineco It looks like after retry detach back off(although it still failed with time out), the attach disk operation could proceed, no need to do manual vm update now, right? 15min is long, while currently I have no idea what's the reasonable num for such timeout value. |
|
Right, no need for a manual VMSS update. |
andyzhangx
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
andyzhangx
changed the title
|
@antoineco after confirmation from azure compute team, the default 15min timeout value is short enough, we should not shorten that timeout value, if there is lots of such timeout issues, I think you may file an azure support ticket to find the root cause or mitigate, thanks. |
|
Will do, thank you for asking. |
|
/lgtm Added to v1.15 milestone since it's a critical bug fix. |
k8s-ci-robot
added
the
lgtm
|
/priority critical-urgent |
k8s-ci-robot
added
the
priority/critical-urgent
This was referenced Jun 7, 2019
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 20, 2019
…8700-upstream-release-1.14 Automated cherry pick of #78700: fix: update vm if detach a non-existing disk
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 21, 2019
…8700-upstream-release-1.13 Automated cherry pick of #78700: fix: update vm if detach a non-existing disk
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 21, 2019
…8700-upstream-release-1.12 Automated cherry pick of #78700: fix: update vm if detach a non-existing disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When got <200, error> after detach disk operation, #78298 would retry detach disk, while it actually would not succeed since the "detaching" disk would not be in returned data disk list, this PR would try to only update vm if detach a non-existing disk.
Which issue(s) this PR fixes:
Fixes #78660
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/kind bug
/priority important-soon
/sig azure
@antoineco could you try this patch if possible, thanks.