Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: retry detach azure disk issue #78700
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
@antoineco could you try this patch if possible, thanks.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andyzhangx
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
I managed to reproduce and the backoff was not canceled this time
However delays are still extremely long:
@andyzhangx is it worth opening a separate issue to discuss that?
@antoineco It looks like after retry detach back off(although it still failed with time out), the attach disk operation could proceed, no need to do manual vm update now, right? 15min is long, while currently I have no idea what's the reasonable num for such timeout value.
@antoineco after confirmation from azure compute team, the default 15min timeout value is short enough, we should not shorten that timeout value, if there is lots of such timeout issues, I think you may file an azure support ticket to find the root cause or mitigate, thanks.