Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere: allow SAML token delegation #78876

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

dougm
Copy link
Member

@dougm dougm commented Jun 10, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

vSphere SAML token must be delegatable when used with the tags API for Zones support.

Issue #77360

Which issue(s) this PR fixes:

Fixes #77360

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

vSphere: allow SAML token delegation (required for Zones support)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 10, 2019
@dougm
Copy link
Member Author

dougm commented Jun 10, 2019

/sig vmware

@k8s-ci-robot k8s-ci-robot added the area/provider/vmware Issues or PRs related to vmware provider label Jun 10, 2019
@dougm
Copy link
Member Author

dougm commented Jun 10, 2019

/assign @frapposelli

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2019
@frapposelli
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2019
@dims
Copy link
Member

dims commented Jun 11, 2019

/retest

@dims
Copy link
Member

dims commented Jun 11, 2019

@dougm is this for 1.15?

@dougm
Copy link
Member Author

dougm commented Jun 11, 2019

@dims, yes, and 1.14.4 too.. will open cherry-pick PRs after this gets merged.

@dims
Copy link
Member

dims commented Jun 11, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8de1569 into kubernetes:master Jun 11, 2019
k8s-ci-robot added a commit that referenced this pull request Jun 20, 2019
…upstream-release-1.14

Automated cherry pick of #78876: vSphere: allow SAML token delegation
dougm added a commit to dougm/cloud-provider-vsphere that referenced this pull request Aug 6, 2019
dougm added a commit to dougm/cloud-provider-vsphere that referenced this pull request Aug 6, 2019
dougm added a commit to dougm/cloud-provider-vsphere that referenced this pull request Aug 6, 2019
dougm added a commit to dougm/cloud-provider-vsphere that referenced this pull request Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/vmware Issues or PRs related to vmware provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAML auth with vSphere and zones API not working
4 participants