Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere: allow SAML token delegation #78876

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@dougm
Copy link
Member

commented Jun 10, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

vSphere SAML token must be delegatable when used with the tags API for Zones support.

Issue #77360

Which issue(s) this PR fixes:

Fixes #77360

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

vSphere: allow SAML token delegation (required for Zones support)
@dougm

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

/sig vmware

@dougm

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

/assign @frapposelli

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frapposelli

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

/lgtm

@dims

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

/retest

@dims

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@dougm is this for 1.15?

@dougm

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

@dims, yes, and 1.14.4 too.. will open cherry-pick PRs after this gets merged.

@dims

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 11, 2019

@k8s-ci-robot k8s-ci-robot merged commit 8de1569 into kubernetes:master Jun 11, 2019

23 checks passed

cla/linuxfoundation dougm authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Jun 20, 2019

Merge pull request #78905 from dougm/automated-cherry-pick-of-#78876-…
…upstream-release-1.14

Automated cherry pick of #78876: vSphere: allow SAML token delegation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.