Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #78672: Enable resize in default gce storageclass #79055

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Jun 14, 2019

Cherry pick of #78672 on release-1.13.

#78672: Enable resize in default gce storageclass

Change-Id: I0eda852543264cc1fdecc113c12dd8e797e6d362
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 14, 2019
@k8s-ci-robot
Copy link
Contributor

@msau42: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 14, 2019
@msau42
Copy link
Member Author

msau42 commented Jun 14, 2019

/kind bug
/priority important-soon
/assign @saad-ali @mikedanese

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 14, 2019
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msau42, saad-ali
To complete the pull request process, please assign mikedanese
You can assign the PR to them by writing /assign @mikedanese in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@msau42: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 7102bdc link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hoegaarden
Copy link
Contributor

Thanks for the PRs, @msau42!

I was wondering why this is labeled as a bug? The original issue #75004 is labeled as feature, and to me it also looks and reads more like a feature. Could you give us some context on why you think it is of such high importance that it needs to go into all currently supported releases?

/cc @kubernetes/patch-release-team @kubernetes/sig-storage-bugs


other PRs/CPs

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 19, 2019
@msau42
Copy link
Member Author

msau42 commented Jun 19, 2019

@hoegaarden this sort of falls in between a feature and a bug. It's a config change that we should have made when we moved the feature to beta to make it easier for users to consume.

@msau42
Copy link
Member Author

msau42 commented Jun 19, 2019

That being said, it's not urgently breaking anyone and is more of a nice to have to improve the user experience.

@hoegaarden
Copy link
Contributor

hoegaarden commented Jun 26, 2019

Consulting https://github.com/kubernetes/community/blob/master/contributors/design-proposals/release/versioning.md#patch-releases I don't think this qualifies as a change that should go into a patch release.

I will close this PR (and the ones on the other release branches).

Please, if you don't agree with that decision, ping me, the @kubernetes/patch-release-team, or re-open the PR(s)!

@hoegaarden
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@hoegaarden: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42 msau42 deleted the automated-cherry-pick-of-#78672-upstream-release-1.13 branch October 19, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants