-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #78672: Enable resize in default gce storageclass #79055
Automated cherry pick of #78672: Enable resize in default gce storageclass #79055
Conversation
Change-Id: I0eda852543264cc1fdecc113c12dd8e797e6d362
@msau42: This PR is not for the master branch but does not have the To approve the cherry-pick, please assign the patch release manager for the release branch by writing The list of patch release managers for each release can be found here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: msau42, saad-ali The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@msau42: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks for the PRs, @msau42! I was wondering why this is labeled as a bug? The original issue #75004 is labeled as feature, and to me it also looks and reads more like a feature. Could you give us some context on why you think it is of such high importance that it needs to go into all currently supported releases? /cc @kubernetes/patch-release-team @kubernetes/sig-storage-bugs other PRs/CPs |
@hoegaarden this sort of falls in between a feature and a bug. It's a config change that we should have made when we moved the feature to beta to make it easier for users to consume. |
That being said, it's not urgently breaking anyone and is more of a nice to have to improve the user experience. |
Consulting https://github.com/kubernetes/community/blob/master/contributors/design-proposals/release/versioning.md#patch-releases I don't think this qualifies as a change that should go into a patch release. I will close this PR (and the ones on the other release branches). Please, if you don't agree with that decision, ping me, the @kubernetes/patch-release-team, or re-open the PR(s)! |
/close |
@hoegaarden: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry pick of #78672 on release-1.13.
#78672: Enable resize in default gce storageclass