Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/util/slice to staging #79203

Merged
merged 5 commits into from Jun 28, 2019
Merged

Move pkg/kubectl/util/slice to staging #79203

merged 5 commits into from Jun 28, 2019

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Jun 20, 2019

/kind cleanup
/sig cli
/area kubectl

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 20, 2019
@nikhita
Copy link
Member

nikhita commented Jun 20, 2019

/cc @seans3

@k8s-ci-robot k8s-ci-robot requested a review from seans3 June 20, 2019 11:43
@seans3
Copy link
Contributor

seans3 commented Jun 21, 2019

/cc @monopole

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 25, 2019

/uncc @derekwaynecarr
/uncc @brendandburns

@seans3
Copy link
Contributor

seans3 commented Jun 25, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
@monopole
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 27, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubelet sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@seans3
Copy link
Contributor

seans3 commented Jun 27, 2019

/remove-area kubelet
/remove-sig node
/remove-sig cluster-lifecycle
/uncc @monopole
/cc @apelisse

@k8s-ci-robot k8s-ci-robot removed the request for review from monopole June 27, 2019 19:25
@k8s-ci-robot k8s-ci-robot removed sig/node Categorizes an issue or PR as relevant to SIG Node. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jun 27, 2019
@apelisse
Copy link
Member

/approve

for vendor/modules.txt

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, damemi, monopole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3
Copy link
Contributor

seans3 commented Jun 27, 2019

/retest

@seans3
Copy link
Contributor

seans3 commented Jun 27, 2019

/test pull-kubernetes-e2e-gce-100-performance

@seans3
Copy link
Contributor

seans3 commented Jun 28, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit e0af9cf into kubernetes:master Jun 28, 2019
@damemi damemi deleted the kubectl-slice branch June 28, 2019 16:12
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79203 from damemi/kubectl-slice
feda2a6 
Move pkg/kubectl/util/slice to staging

Kubernetes-commit: e0af9cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seans3 seans3 Awaiting requested review from seans3

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@monopole monopole

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@damemi @nikhita @seans3 @monopole @apelisse @k8s-ci-robot