Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl attach test: wait for input before proceeding #79235

Merged
merged 1 commit into from Sep 6, 2019
Merged

kubectl attach test: wait for input before proceeding #79235

merged 1 commit into from Sep 6, 2019

Conversation

justinsb
Copy link
Member

This way we know stdin is attached and we are in a known state.

/kind failing-test

Fixes #73099

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2019
@justinsb
Copy link
Member Author

/retest

Flake: [resource constraints: 1 constraints violated: [container fluentd-gcp-v3.2.0-slzfs/fluentd-gcp is using 237.1328125/230 MB of memory]]]

@justinsb justinsb added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 20, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 20, 2019
@justinsb justinsb mentioned this pull request Jun 20, 2019
Closed
@justinsb
Copy link
Member Author

Output seems to show it passing, so ...

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2019
@justinsb
kubectl attach test: wait for input before proceeding
0c57ad0 
This way we know stdin is attached and we are in a known state.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2019
@justinsb justinsb added sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl and removed sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 9, 2019
@justinsb
Copy link
Member Author

justinsb commented Jul 9, 2019

@soltysh you previously asked for a simplification of this test, and you were right! This adds a little complexity to the command we run, so that we wait for an attach, but then the test logic is much simpler because there's only one path (cf #73099 which describes the various possible paths previously)

@xmudrii
Copy link
Member

xmudrii commented Sep 5, 2019

@justinsb @soltysh @liggitt The underlying issue is targeted for 1.16. If this should be part of the 1.16 release cycle, is it possible to get it merged by 9/9?

soltysh
soltysh approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, let's merge it and see how the flakiness changes.
/lgtm
/approve
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 6, 2019
@soltysh
Copy link
Contributor

soltysh commented Sep 6, 2019

Thanks @justinsb and sorry for delays 😊

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1866891 into kubernetes:master Sep 6, 2019
giuseppe added a commit to giuseppe/origin that referenced this pull request Sep 18, 2019
@giuseppe
Bug 1752800: UPSTREAM: 79235: kubectl attach test: wait for input bef…
f497865 
…ore proceeding

This way we know stdin is attached and we are in a known state.

ref: kubernetes/kubernetes#79235

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this pull request Sep 18, 2019
Closed
giuseppe added a commit to giuseppe/origin that referenced this pull request Sep 18, 2019
@giuseppe
UPSTREAM: 79235: Bug 1752800: kubectl attach test: wait for input bef…
60db8a8 
…ore proceeding

This way we know stdin is attached and we are in a known state.

ref: kubernetes/kubernetes#79235

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/origin that referenced this pull request Sep 18, 2019
@giuseppe
UPSTREAM: 79235: Bug 1752800: kubectl attach test: wait for input bef…
0c0482b 
…ore proceeding

This way we know stdin is attached and we are in a known state.

ref: kubernetes/kubernetes#79235

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@smarterclayton
Copy link
Contributor

I think this breaks the intent of the test.

Kubectl attach isn’t supposed to race here.

@soltysh
Copy link
Contributor

soltysh commented Oct 2, 2019

Not quite, we've seen this being racy also in openshift, mostly problem was on the container engine side.

@justinsb
Copy link
Member Author

justinsb commented Oct 2, 2019

Interesting - that certainly wasn't my intent @smarterclayton - sorry!

I'm poking around, trying to understand what the previous race was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

The test "Simple pod should support inline execution and attach" is inherently racy.
5 participants
@justinsb @xmudrii @soltysh @k8s-ci-robot @smarterclayton