Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use framework.ExpectEqual in storage e2e test #79755

Merged
merged 1 commit into from
Jul 5, 2019
Merged

feat: use framework.ExpectEqual in storage e2e test #79755

merged 1 commit into from
Jul 5, 2019

Conversation

draveness
Copy link
Contributor

/kind cleanup
/priority backlog
/assign @oomichi

What this PR does / why we need it:

use framework.ExpectEqual in storage e2e test

Which issue(s) this PR fixes:

ref: #79686

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 4, 2019
@draveness draveness force-pushed the feature/use-framework-expect-equal-in-storage branch from 2386d37 to 3f98449 Compare July 4, 2019 01:26
@draveness draveness force-pushed the feature/use-framework-expect-equal-in-storage branch from 3f98449 to 587f44d Compare July 4, 2019 01:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2019
@draveness draveness mentioned this pull request Jul 4, 2019
Closed
29 tasks
@s-ito-ts
Copy link
Contributor

s-ito-ts commented Jul 4, 2019

There seems to be some code that can be replaced with ExpectEqual ().
https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/regional_pd.go#L272-L273
https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/regional_pd.go#L281-L282
https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/volume_metrics.go#L418-L419
https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/volume_metrics.go#L434-L436
https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/utils/utils.go#L93-L95

@draveness draveness force-pushed the feature/use-framework-expect-equal-in-storage branch from 587f44d to 4c2e77a Compare July 4, 2019 14:24
@draveness
Copy link
Contributor Author

There seems to be some code that can be replaced with ExpectEqual ().
https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/regional_pd.go#L272-L273

https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/regional_pd.go#L281-L282

https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/volume_metrics.go#L418-L419

https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/volume_metrics.go#L434-L436

https://github.com/kubernetes/kubernetes/blob/587f44d3c6773b80af248a4482048807e8f56eb8/test/e2e/storage/utils/utils.go#L93-L95

Thank you, comments have been addressed.

@s-ito-ts
Copy link
Contributor

s-ito-ts commented Jul 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2019
oomichi
oomichi reviewed Jul 5, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1addcf4 into kubernetes:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@copejon copejon Awaiting requested review from copejon

@msau42 msau42 Awaiting requested review from msau42

Assignees

@oomichi oomichi

@s-ito-ts s-ito-ts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@draveness @s-ito-ts @k8s-ci-robot @oomichi