Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bazel: release tars should use arch in the name #80266

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@javier-b-perez
Copy link
Contributor

commented Jul 17, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Build release-tars with bazel and use the arch in the docker tag name.

Which issue(s) this PR fixes:
Fixes #80262

Special notes for your reviewer:
This replicate the logic for make build in #80047

Does this PR introduce a user-facing change?:

ACTION REQUIRED: container images tar files for 'amd64' will now contain the architecture in the RepoTags manifest.json section.
If you are using docker manifests there are not visible changes.
@javier-b-perez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

/hold
need more testing

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

/test pull-kubernetes-e2e-kind

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

[kind consumes these images. HPA failure is currently expected in the kind job, there's a revert pending]

build/BUILD Outdated Show resolved Hide resolved
@javier-b-perez javier-b-perez force-pushed the javier-b-perez:bazel-build branch from 730f8a8 to b6508bc Jul 17, 2019
@javier-b-perez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

In my test is working as intended now:
make bazel-release
tar xfz bazel-bin/build/release-tars/kubernetes-server-linux-amd64.tar.gz
...
cat manifest.json
"RepoTags": ["k8s.gcr.io/kube-apiserver-amd64:v1.16.0-alpha.1.15_b6508bc9e8cf96"]

@javier-b-perez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

/priority important-soon
/sig release
/assign @dims

@javier-b-perez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

/assign @cblecker

Copy link
Member

left a comment

/lgtm
/approve
/hold
calling for a check on blast radius before proceeding 😅

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, javier-b-perez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

@javier-b-perez: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind 730f8a8 link /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@javier-b-perez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

/retest

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

@javier-b-perez
instead of NONE for release note we should add a release note IMO, given these are release artifacts.

if the release note is prefixed with ACTION REQUIRED: the bot should add the label release-note-action-required and then the release note tooling will pick this up for better visibility on release.

@javier-b-perez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@javier-b-perez
instead of NONE for release note we should add a release note IMO, given these are release artifacts.

if the release note is prefixed with ACTION REQUIRED: the bot should add the label release-note-action-required and then the release note tooling will pick this up for better visibility on release.

you mean something like this?

ACTION REQUIRED: container images tar files for 'amd64' will contain the architecture in the RepoTags manifest.json section.
If you are using docker manifests there are not visible changes.
@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

you mean something like this?

yes, SGTM. would only change will contain -> will now contain

@javier-b-perez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

you mean something like this?

yes, SGTM. would only change will contain -> will now contain

done, thanks

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

/hold cancel

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5de4134 into kubernetes:master Jul 18, 2019
23 checks passed
23 checks passed
cla/linuxfoundation javier-b-perez authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.