Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bazel: release tars should use arch in the name #80266

Merged
merged 1 commit into from
Jul 18, 2019
Merged

build: bazel: release tars should use arch in the name #80266

merged 1 commit into from
Jul 18, 2019

Conversation

javier-b-perez
Copy link
Contributor

@javier-b-perez javier-b-perez commented Jul 17, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Build release-tars with bazel and use the arch in the docker tag name.

Which issue(s) this PR fixes:
Fixes #80262

Special notes for your reviewer:
This replicate the logic for make build in #80047

Does this PR introduce a user-facing change?:

ACTION REQUIRED: container images tar files for 'amd64' will now contain the architecture in the RepoTags manifest.json section.
If you are using docker manifests there are not visible changes.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 17, 2019
@javier-b-perez
Copy link
Contributor Author

/hold
need more testing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2019
@BenTheElder
Copy link
Member

/test pull-kubernetes-e2e-kind

@BenTheElder
Copy link
Member

[kind consumes these images. HPA failure is currently expected in the kind job, there's a revert pending]

BenTheElder
BenTheElder reviewed Jul 17, 2019
View reviewed changes
build/BUILD Outdated Show resolved Hide resolved
@javier-b-perez
Copy link
Contributor Author

In my test is working as intended now:
make bazel-release
tar xfz bazel-bin/build/release-tars/kubernetes-server-linux-amd64.tar.gz
...
cat manifest.json
"RepoTags": ["k8s.gcr.io/kube-apiserver-amd64:v1.16.0-alpha.1.15_b6508bc9e8cf96"]

@javier-b-perez
Copy link
Contributor Author

/priority important-soon
/sig release
/assign @dims

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 17, 2019
@javier-b-perez
Copy link
Contributor Author

/assign @cblecker

BenTheElder
BenTheElder approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
calling for a check on blast radius before proceeding 😅

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, javier-b-perez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 17, 2019 •
edited
Loading

@javier-b-perez: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind 730f8a889e48f04e7a950eba7f22669296e402da link /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@javier-b-perez
Copy link
Contributor Author

/retest

@neolit123
Copy link
Member

@javier-b-perez
instead of NONE for release note we should add a release note IMO, given these are release artifacts.

if the release note is prefixed with ACTION REQUIRED: the bot should add the label release-note-action-required and then the release note tooling will pick this up for better visibility on release.

@javier-b-perez
Copy link
Contributor Author

@javier-b-perez
instead of NONE for release note we should add a release note IMO, given these are release artifacts.

if the release note is prefixed with ACTION REQUIRED: the bot should add the label release-note-action-required and then the release note tooling will pick this up for better visibility on release.

you mean something like this?

ACTION REQUIRED: container images tar files for 'amd64' will contain the architecture in the RepoTags manifest.json section.
If you are using docker manifests there are not visible changes.

@neolit123
Copy link
Member

you mean something like this?

yes, SGTM. would only change will contain -> will now contain

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 17, 2019
@javier-b-perez
Copy link
Contributor Author

you mean something like this?

yes, SGTM. would only change will contain -> will now contain

done, thanks

@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2019
@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5de4134 into kubernetes:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@fejta fejta Awaiting requested review from fejta

Assignees

@dims dims

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core k8s images should have 'amd64' in the container name
6 participants
@javier-b-perez @BenTheElder @k8s-ci-robot @neolit123 @cblecker @dims