Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #80675: fix-file-discovery #80728

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Automated cherry pick of #80675: fix-file-discovery #80728

merged 3 commits into from
Aug 7, 2019

Conversation

neolit123
Copy link
Member

Cherry pick of #80675 on release-1.14.

#80675: autogenerated

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 29, 2019
@k8s-ci-robot k8s-ci-robot requested review from detiber and kad July 29, 2019 22:53
@neolit123 neolit123 force-pushed the automated-cherry-pick-of-#80675-origin-release-1.14 branch from f81c2e2 to 3b26c28 Compare July 29, 2019 23:01
@neolit123
Copy link
Member Author

/kind bug
/priority critical-urgent
/assign @fabriziopandini

this one required minor rebase (v1beta1 vs v1beta2), so please double check the last commit.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 29, 2019
@fabriziopandini
Copy link
Member

/test pull-kubernetes-integration

@fabriziopandini
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini
Copy link
Member

@kubernetes/patch-release-team
PTAL

@neolit123 neolit123 changed the title Automated cherry pick of #80675: autogenerated Automated cherry pick of #80675: fix-file-discovery Jul 31, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1bef93b into kubernetes:release-1.14 Aug 7, 2019
@fabriziopandini
Copy link
Member

Thanks, @kubernetes/patch-release-team!
Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber Awaiting requested review from detiber

@kad kad Awaiting requested review from kad

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neolit123 @fabriziopandini @k8s-ci-robot @tpepper