Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raw extension openapi definition #80773

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@jennybuckley
Copy link
Contributor

commented Jul 30, 2019

What type of PR is this?
/kind bug
/sig api-machinery
/priority important-longterm

What this PR does / why we need it:
Changes the definition of RawExtension to this (adding json:"-")

type RawExtension struct {
    ...
    Raw []byte `json:"-" protobuf:"bytes,1,opt,name=raw"`
    ...
}

I noticed that this removes Raw from the openapi defintion of it, making it just type: object, without changing how it is marshalled or unmarshalled (since we have custom functions for that). This fixes a known issue with the client side validation of RawExtension

Which issue(s) this PR fixes:
Fixes #55890

Does this PR introduce a user-facing change?:

Fixed a bug with the openAPI definition for io.k8s.apimachinery.pkg.runtime.RawExtension, which previously required a field "raw" to be specified
@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

/retest

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

/assign @roycaihw

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

/retest

2 similar comments
@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

/retest

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

/retest

@roycaihw

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

/lgtm

This doesn't introduce any user-facing change in apiserver handling a request (besides the openapi spec itself is visible to user), but it will cause a few client-side change that are user-facing (kubectl and the openapi-generated clients won't require raw in a field of RawExtension type and/or error on unknown fields). Could you add a release note mentioning that the spec is fixed?

also please squash the first and the third commits

jennybuckley added 2 commits Aug 1, 2019

@jennybuckley jennybuckley force-pushed the jennybuckley:fix-rawextension branch from 329da0c to ef30bd6 Aug 1, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 1, 2019

@jennybuckley

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

/retest
@roycaihw I think this is ready now

@lavalamp

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

nice find

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennybuckley, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roycaihw

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 22, 2019

@k8s-ci-robot k8s-ci-robot merged commit 3dbedef into kubernetes:master Aug 23, 2019

23 checks passed

cla/linuxfoundation jennybuckley authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.