New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix raw extension openapi definition #80773
Fix raw extension openapi definition #80773
Conversation
/retest |
/assign @roycaihw |
/retest |
2 similar comments
/retest |
/retest |
/lgtm This doesn't introduce any user-facing change in apiserver handling a request (besides the openapi spec itself is visible to user), but it will cause a few client-side change that are user-facing (kubectl and the openapi-generated clients won't require also please squash the first and the third commits |
329da0c
to
ef30bd6
Compare
/retest |
nice find /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jennybuckley, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind bug
/sig api-machinery
/priority important-longterm
What this PR does / why we need it:
Changes the definition of RawExtension to this (adding
json:"-"
)I noticed that this removes Raw from the openapi defintion of it, making it just
type: object
, without changing how it is marshalled or unmarshalled (since we have custom functions for that). This fixes a known issue with the client side validation of RawExtensionWhich issue(s) this PR fixes:
Fixes #55890
Does this PR introduce a user-facing change?: