New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NormalizeScore plugin set from config API. #80930
Remove NormalizeScore plugin set from config API. #80930
Conversation
Hi @liu-cong. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/ok-to-test |
/test pull-kubernetes-integration |
/lgtm |
/assign @erictune |
/test pull-kubernetes-integration |
5 similar comments
/test pull-kubernetes-integration |
/test pull-kubernetes-integration |
/test pull-kubernetes-integration |
/test pull-kubernetes-integration |
/test pull-kubernetes-integration |
FYI @draveness to ensure your ongoing PRs are aligned. |
You told me offline that you think the scheduler will ignore an unknown field, in the unlikely case that someone chose to put this property in their config file (even though it is a no-op). Based on that, and the fact it had no effect: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, erictune, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That's right. I created a small example that shows this: https://play.golang.org/p/MoYt50z9BPJ Please also note that we have not released even the alpha version of the config for NormalizeScore plugins. So, it should be fine to change it. |
/test pull-kubernetes-e2e-gce |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
NormalizeScore
plugin set in the config API is not used by the code. Instead, if user wants to implementNormalizeScore
, they should configureScorePlugin
in the config API and implementScoreWithNormalizePlugin
interface.This API isn't currently in use - the scheduler framework is not fully implemented yet. Therefore changing this API should have little to no impact to users.
More details in issue.
Which issue(s) this PR fixes:
Fixes #80908
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Scheduler Framework
/sig scheduling