Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NormalizeScore plugin set from config API. #80930

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@liu-cong
Copy link
Contributor

commented Aug 2, 2019

What type of PR is this?
/kind api-change

What this PR does / why we need it:
NormalizeScore plugin set in the config API is not used by the code. Instead, if user wants to implement NormalizeScore, they should configure ScorePlugin in the config API and implement ScoreWithNormalizePlugin interface.

This API isn't currently in use - the scheduler framework is not fully implemented yet. Therefore changing this API should have little to no impact to users.

More details in issue.

Which issue(s) this PR fixes:

Fixes #80908

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NormalizeScore plugin set is removed from scheduler framework config API. Use ScorePlugin only.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Scheduler Framework

/sig scheduling

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Hi @liu-cong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from derekwaynecarr and Huang-Wei Aug 2, 2019

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 2, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

/ok-to-test

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

/test pull-kubernetes-integration

@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

/lgtm
/approve

@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

/assign @erictune

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

/test pull-kubernetes-integration

5 similar comments
@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

/test pull-kubernetes-integration

@Huang-Wei

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

FYI @draveness to ensure your ongoing PRs are aligned.

@erictune

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

You told me offline that you think the scheduler will ignore an unknown field, in the unlikely case that someone chose to put this property in their config file (even though it is a no-op). Based on that, and the fact it had no effect:
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, erictune, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bsalamat

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

You told me offline that you think the scheduler will ignore an unknown field, in the unlikely case that someone chose to put this property in their config file (even though it is a no-op).

That's right. I created a small example that shows this: https://play.golang.org/p/MoYt50z9BPJ

Please also note that we have not released even the alpha version of the config for NormalizeScore plugins. So, it should be fine to change it.

@liu-cong

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

/test pull-kubernetes-e2e-gce

@liu-cong liu-cong referenced this pull request Aug 21, 2019
6 of 6 tasks complete

@k8s-ci-robot k8s-ci-robot merged commit 1a53325 into kubernetes:master Aug 21, 2019

23 checks passed

cla/linuxfoundation liu-cong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.