Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NormalizeScore plugin set from config API. #80930

Merged
merged 1 commit into from Aug 21, 2019

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Aug 2, 2019

What type of PR is this?
/kind api-change

What this PR does / why we need it:
NormalizeScore plugin set in the config API is not used by the code. Instead, if user wants to implement NormalizeScore, they should configure ScorePlugin in the config API and implement ScoreWithNormalizePlugin interface.

This API isn't currently in use - the scheduler framework is not fully implemented yet. Therefore changing this API should have little to no impact to users.

More details in issue.

Which issue(s) this PR fixes:

Fixes #80908

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NormalizeScore plugin set is removed from scheduler framework config API. Use ScorePlugin only.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Scheduler Framework

/sig scheduling

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @liu-cong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 2, 2019

@bsalamat @ahg-g

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ahg-g
Copy link
Member

ahg-g commented Aug 3, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2019
@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 4, 2019

/test pull-kubernetes-integration

@ahg-g
Copy link
Member

ahg-g commented Aug 4, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2019
@ahg-g
Copy link
Member

ahg-g commented Aug 4, 2019

/assign @erictune

@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 6, 2019

/test pull-kubernetes-integration

5 similar comments
@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 6, 2019

/test pull-kubernetes-integration

@liu-cong
Copy link
Contributor Author

liu-cong commented Aug 7, 2019

/test pull-kubernetes-integration

@Huang-Wei
Copy link
Member

FYI @draveness to ensure your ongoing PRs are aligned.

@erictune
Copy link
Member

You told me offline that you think the scheduler will ignore an unknown field, in the unlikely case that someone chose to put this property in their config file (even though it is a no-op). Based on that, and the fact it had no effect:
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, erictune, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@bsalamat
Copy link
Member

You told me offline that you think the scheduler will ignore an unknown field, in the unlikely case that someone chose to put this property in their config file (even though it is a no-op).

That's right. I created a small example that shows this: https://play.golang.org/p/MoYt50z9BPJ

Please also note that we have not released even the alpha version of the config for NormalizeScore plugins. So, it should be fine to change it.

@bsalamat bsalamat added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 21, 2019
@liu-cong
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 1a53325 into kubernetes:master Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler Framework: Consolidate NormalizeScore plugin set into Score plugin set in config API
7 participants