Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade release-1.13 to go1.11.13 #81398

Closed
wants to merge 1 commit into from
Closed

upgrade release-1.13 to go1.11.13 #81398

wants to merge 1 commit into from

Conversation

warmchang
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
upgrade release-1.13 to go1.11.13

Ref: #79912 (comment), https://github.com/kubernetes/kubernetes/issues/73286

Which issue(s) this PR fixes:
Fixes #75780

Special notes for your reviewer:
@cblecker

Does this PR introduce a user-facing change?:

upgrade release-1.13 to go1.11.13

@warmchang
upgrade release-1.13 to go 1.11.13
9ec6286 
Signed-off-by: William Zhang <zhang.wanmin@zte.com.cn>
@k8s-ci-robot
Copy link
Contributor

@warmchang: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please ping the kubernetes/patch-release-team in a comment when ready.

See also Kubernetes Patch Releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: warmchang
To complete the pull request process, please assign ixdy
You can assign the PR to them by writing /assign @ixdy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 14, 2019
@warmchang
Copy link
Contributor Author

/assign @cblecker

@warmchang
Copy link
Contributor Author

/hold

Until the image "k8s.gcr.io/kube-cross:v1.11.13-1" generated:

https://console.cloud.google.com/gcr/images/google-containers/GLOBAL/kube-cross?gcrImageListsize=30

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 15, 2019 •
edited

@warmchang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 9ec6286 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-bazel-build 9ec6286 link /test pull-kubernetes-bazel-build
pull-kubernetes-e2e-gce 9ec6286 link /test pull-kubernetes-e2e-gce
pull-kubernetes-cross 9ec6286 link /test pull-kubernetes-cross
pull-kubernetes-kubemark-e2e-gce-big 9ec6286 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-godeps 9ec6286 link /test pull-kubernetes-godeps
pull-kubernetes-verify 9ec6286 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cblecker
Copy link
Member

/hold
Do not build. The bazel stuff needs to be fixed up first.

@cblecker cblecker mentioned this pull request Aug 15, 2019
Closed
@warmchang
Copy link
Contributor Author

/hold
Do not build. The bazel stuff needs to be fixed up first.

/area release-team release-eng
/priority important-soon

Who can help to make & upload "kube-cross:v1.11.13-1" image? Thanks.

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2019
@tpepper
Copy link
Member

tpepper commented Aug 16, 2019

/priority critical-urgent
/sig release

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 16, 2019
@cblecker
Copy link
Member

@warmchang This PR is incomplete (bazel hasn't been updated/fixed). Unfortunately, due to release timelines we need to get this fixed. @BenTheElder and I are working on this in #81542.

Thank you for wanting to help. If we had more time, I would try to guide you through the changes required.

/close

@k8s-ci-robot
Copy link
Contributor

@cblecker: Closed this PR.

In response to this:

@warmchang This PR is incomplete (bazel hasn't been updated/fixed). Unfortunately, due to release timelines we need to get this fixed. @BenTheElder and I are working on this in #81542.

Thank you for wanting to help. If we had more time, I would try to guide you through the changes required.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@warmchang warmchang deleted the go1.11.13 branch September 12, 2019 07:53
@warmchang warmchang restored the go1.11.13 branch June 6, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy Awaiting requested review from ixdy

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@cblecker cblecker

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@warmchang @k8s-ci-robot @cblecker @tpepper