Consider EphemeralContainers in GetResourceRequest

[tedyu]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Currently resource requests from EphemeralContainers are not counted in GetResourceRequest.

This PR adds resource requests from EphemeralContainers to the result.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedyu
To complete the pull request process, please assign ravisantoshgudimetla
You can assign the PR to them by writing /assign @ravisantoshgudimetla in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[draveness]

I'm not sure it is necessary to add the ephemeral containers resource request, as the KEP mentioned resources field is disallowed in ephemeral containers for now and there are no guaranteed resources:

Some fields of v1.Container imply consequences for the entire pod. For example, one would expect setting resources to increase resources allocated to the pod, but this is not yet supported. We will disallow resources in Ephemeral Containers.

There are no guaranteed resources for ad-hoc troubleshooting. If troubleshooting causes a pod to exceed its resource limit it may be evicted.

[ahg-g]

+1 to what @draveness said. also from the KEP: "Ephemeral Containers lack guarantees for resources or execution"

[ahg-g]

/close

[k8s-ci-robot]

@ahg-g: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tedyu]

Related :
#81838 (comment)