Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextension: promote CRD defaulting to beta #81872

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@sttts
Copy link
Contributor

commented Aug 23, 2019

/kind feature

The CustomResourceDefaulting feature is promoted to beta and enabled by default. Defaults may be specified in structural schemas via the `apiextensions.k8s.io/v1` API. See https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#specifying-a-structural-schema for details.
@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

/assign @liggitt

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 24, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts sttts force-pushed the sttts:sttts-crd-defaulting-beta branch from dfb0853 to 0e93b32 Aug 24, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/XXL labels Aug 24, 2019

@sttts sttts force-pushed the sttts:sttts-crd-defaulting-beta branch from 0e93b32 to 73ace96 Aug 24, 2019

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

/retest

@xmudrii

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

@sttts @liggitt Hello! I'm the bug triage lead for the 1.16 release cycle and I'd just like to remind that the code freeze is starting on August 29th EOD PST (about 5 days from now). Once the code freeze starts, only release-blocking PRs will be considered for merging.

@sttts sttts force-pushed the sttts:sttts-crd-defaulting-beta branch from 73ace96 to 03bff07 Aug 26, 2019

errors: []validationMatch{
forbidden("spec", "validation", "openAPIV3Schema", "properties[a]", "default"), // disabled feature-gate
},
},
{
name: "defaults with enabled feature gate via v1beta1",
name: "defaults via v1beta1",

This comment has been minimized.

Copy link
@liggitt

liggitt Aug 26, 2019

Member

until the default is locked on, I'd keep the explicit enabledFeatures: []featuregate.Feature{features.CustomResourceDefaulting} in the test setup (applies to multiple places)

@sttts sttts force-pushed the sttts:sttts-crd-defaulting-beta branch from 03bff07 to 5a9d272 Aug 26, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Aug 26, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 26, 2019

@sttts sttts force-pushed the sttts:sttts-crd-defaulting-beta branch from 5a9d272 to 927a93d Aug 26, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 26, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 26, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

/retest

2 similar comments
@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 45b0b78 into kubernetes:master Aug 26, 2019

24 checks passed

cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.