Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiextensions: set 'metadata.generation: 1' on read from etcd if not set #82005

Merged
merged 1 commit into from Aug 27, 2019
Merged

apiextensions: set 'metadata.generation: 1' on read from etcd if not set #82005

merged 1 commit into from Aug 27, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Aug 27, 2019

/kind bug

Fixes #68998

Add metadata.generation=1 to old CustomResources.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 27, 2019
@sttts sttts added this to the v1.16 milestone Aug 27, 2019
@sttts sttts added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 27, 2019
@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@sttts sttts changed the title apiextensions: add tests that we coerce 'metadata.generation: null' correctly apiextensions: set 'metadata.generation: 1' on read from etcd if not set Aug 27, 2019
@sttts sttts force-pushed the sttts-crds-coerce-generation branch from c814f9e to 84d29fc Compare August 27, 2019 08:49
@sttts sttts added this to Required for GA, in progress in Custom Resource Definitions Aug 27, 2019
@liggitt
Copy link
Member

liggitt commented Aug 27, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1698765 into kubernetes:master Aug 27, 2019
@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Custom Resource Definitions
Complete
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Custom resources created in old versions don't have .metadata.generation
3 participants
@sttts @liggitt @k8s-ci-robot