-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gonvml module and remove CGO dependency. #82342
Conversation
Signed-off-by: Carlos de Paula <me@carlosedp.com>
Welcome @carlosedp! |
Hi @carlosedp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @dchen1107 |
/assign
:O can you elaborate on this a little bit? so we lose nvidia GPU cAdvisor status, but everything else works? |
/ok-to-test |
This stubs out the Nvidia management module when CGO is not available. When built without CGO, cAdvisor works normally just without the Nvidia GPU management. |
/kind cleanup |
/lgtm |
/approve for root |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, carlosedp, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Remove CGO dependency created by gonvml module. The module has been bumped with stubs for nocgo allowing K8s and cAdvisor to be built with full features without CGO dependency (except the Nvidia GPU cAdvisor features from this module).
This is the first PR to support Risc-V architecture, additional module bumps to follow.
Does this PR introduce a user-facing change?:
Signed-off-by: Carlos de Paula me@carlosedp.com