Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #82579: Expose etcd metric port in tests #82686

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Automated cherry pick of #82579: Expose etcd metric port in tests #82686

merged 1 commit into from
Sep 13, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 13, 2019

Cherry pick of #82579 on release-1.16.

#82579: Expose etcd metric port in tests

@mm4tt @liggitt
Expose etcd metric port in tests
bd0518d 
This is to allow scraping etcd metrics in scalabiblity tests.
This was already done in
kubernetes#77657, but then the logic
got changed when introducing mtls in
kubernetes#77561 and the new etcd
metric port 2382 is currently only exposed on localhost.

Ref. kubernetes/perf-tests#786
@k8s-ci-robot
Copy link
Contributor

@liggitt: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #82579.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2019
@k8s-ci-robot
Copy link
Contributor

@liggitt: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 13, 2019
@liggitt liggitt mentioned this pull request Sep 13, 2019
Merged
@justaugustus
Copy link
Member

Approved on behalf of Release Managers:

/lgtm
/approve

/priority critical-urgent
/kind failing-test bug

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus justaugustus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 13, 2019
@justaugustus
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 13, 2019
@alejandrox1 alejandrox1 mentioned this pull request Sep 13, 2019
Closed
This was referenced Sep 13, 2019
Merged
Merged
@k8s-ci-robot k8s-ci-robot merged commit 01a5d09 into kubernetes:release-1.16 Sep 13, 2019
@liggitt liggitt mentioned this pull request Sep 13, 2019
Merged
@wojtek-t
Copy link
Member

@liggitt - thanks a lot for fixing that!

@wojtek-t
Copy link
Member

Opened kubernetes/perf-tests#797 as a follow up how we can avoid that in the future.

@liggitt liggitt deleted the automated-cherry-pick-of-#82579-upstream-release-1.16 branch September 13, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @justaugustus @wojtek-t @mm4tt