Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18 #82855

Merged
merged 1 commit into from Sep 26, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Sep 19, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
labelAlphaNodeRoleExcludeBalancer is to be removed in 1.17

This PR delays the removal of the label handling to later release.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 19, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Sep 19, 2019

/test pull-kubernetes-e2e-gce-100-performance

@yastij
Copy link
Member

yastij commented Sep 19, 2019

/assign @andrewsykim

Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Can you also add a release-note for this ?

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 19, 2019
@andrewsykim
Copy link
Member

Is this comment relevant kubernetes/enhancements#1144 (comment)? I feel that removing this after 1 release is pretty aggressive and if it's not that much work to support it longer term and not break users I think we should.

@andrewsykim
Copy link
Member

IMO this something we can support longer with minimal effort and I think we should give users more than 1 release to make the necessary changes.

/assign @thockin

@yastij
Copy link
Member

yastij commented Sep 19, 2019

@andrewsykim - If we do have known users for this, we can definitely wait

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2019
@tedyu tedyu changed the title Remove labelAlphaNodeRoleExcludeBalancer Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18 Sep 19, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 19, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Sep 19, 2019

@andrewsykim @yastij
I have updated the PR.

Please take another look.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 19, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Sep 25, 2019

@andrewsykim
Can you take another look ?

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I often just say "after 1.17", meaning I don't have to update it again if we push it again :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedyu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 37c3a4d into kubernetes:master Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 26, 2019
@smarterclayton
Copy link
Contributor

The KEP is updated with dates, once that is merged the email will go out to Kubernetes-dev with the described process (probably linked to a migration doc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants