New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18 #82855
Conversation
1bce3bc
to
a1a3dfa
Compare
/test pull-kubernetes-e2e-gce-100-performance |
/assign @andrewsykim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can you also add a release-note for this ?
Is this comment relevant kubernetes/enhancements#1144 (comment)? I feel that removing this after 1 release is pretty aggressive and if it's not that much work to support it longer term and not break users I think we should. |
IMO this something we can support longer with minimal effort and I think we should give users more than 1 release to make the necessary changes. /assign @thockin |
@andrewsykim - If we do have known users for this, we can definitely wait |
a1a3dfa
to
fd8f2bd
Compare
@andrewsykim @yastij Please take another look. |
@andrewsykim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I often just say "after 1.17", meaning I don't have to update it again if we push it again :)
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tedyu, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The KEP is updated with dates, once that is merged the email will go out to Kubernetes-dev with the described process (probably linked to a migration doc) |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
labelAlphaNodeRoleExcludeBalancer is to be removed in 1.17
This PR delays the removal of the label handling to later release.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: